Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#4263 closed enhancement (fixed)

Maybe update bp_core_set_uri_globals() for AJAX detection

Reported by: djpaul's profile DJPaul Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

I noticed bp_core_set_uri_globals() has an "Ajax or not?" check. Do we need to update this for 1.6 now that the AJAXURL has changed to admin-ajax.php? I'm not sure what the purpose of this check is.

Attachments (1)

4263.01.patch (502 bytes) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
13 years ago

I think we need this check, because proper path detection is necessary for determining current component, action, etc. Also, I think we need the wp-load.php logic for backward compatibility (themes that still register the old version of ajaxurl). But our primary check should be for WP's DOING_AJAX. See attached patch.

#2 @DJPaul
13 years ago

Thanks for the patch, Boone. As we'll be testing the ajaxurl change in beta, I think it's safe enough to put this in and test both at the same time.

#3 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6103]) Update bp_core_set_uri_globals() to check for DOING_AJAX when inspecting the request URI.
This is required because of 1.6's change to the javascript ajaxurl variable. The check for wp-load.php remains for backwards compatibility.

Fixes #4263, props boonebgorges

Note: See TracTickets for help on using tickets.