Child Page - Page Titles

[mwbarker]

If you assign BuddyPress pages as child pages, the page titles are not displayed correctly in the browser.

i.e. for the main Groups Directory page.

If it is a main (parent) page, title displays
User Groups Directory | Site Title

If it is a child page, title displays
Directory| Site TItle

You should be assign BuddyPress pages as child pages without breaking the page title generated in the <title> tags.

[DJPaul]

Moving to 1.6 for investigation.

[DJPaul]

The issue seems to be in the bp_get_name_from_root_slug() function. I've attached a patch that seems to work, but would appreciate someone to test this on lots of different combinations of page/component mappings, or feedback from another dev, before commit.

[boonebgorges]

I'll have to do some more testing, but I'm guessing it'll be necessary to check *both* the root_slug and slug properties. So a decision will have to be made about order of precedence.

[DJPaul]

Moved to a future release as Boone and I don't think we should make this change at this stage of 1.6. As we are already in beta and have no unit test coverage for this, we could break things if we missed a non-obvious case by doing this in a hurry.

[k12onos]

The patch does not work anymore on 1.6.1. I would really appreciate it if you could update the patch to work on 1.6.1 since 1.7 release will take some time.

[jkudish]

refresh patch, checking both slug and root_slug

[boonebgorges]

Ugh, this is the kind of thing that's scary to fix without unit tests. At the very least, it'd be nice if someone had the time to do some manual tests with different kinds of nested setups, to make sure that potential slug/root_slug conflicts are detected correctly.

[jkudish]

I agree that it needs more testing. FWIW, however, I did test at least a few basic scenarios before submitting the patch :)

[johnjamesjacoby]

(In [6616]) Fix bug causing page name/title to be incorrect when directory page has parntes. Props jkudish. Fixes #4242.