Skip to:
Content

#4242 closed defect (bug) (fixed)

Child Page - Page Titles

Reported by: mwbarker Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.5.5
Component: Core Keywords: has-patch needs-testing
Cc: jkudish

Description

If you assign BuddyPress pages as child pages, the page titles are not displayed correctly in the browser.

i.e. for the main Groups Directory page.

If it is a main (parent) page, title displays
User Groups Directory | Site Title

If it is a child page, title displays
Directory| Site TItle

You should be assign BuddyPress pages as child pages without breaking the page title generated in the <title> tags.

Attachments (2)

4242-1.patch (639 bytes) - added by DJPaul 23 months ago.
4242-2.diff (693 bytes) - added by jkudish 18 months ago.
refresh patch, checking both slug and root_slug

Download all attachments as: .zip

Change History (14)

comment:1 DJPaul23 months ago

  • Milestone changed from Awaiting Review to 1.6

Moving to 1.6 for investigation.

DJPaul23 months ago

comment:2 DJPaul23 months ago

  • Keywords has-patch dev-feedback added

The issue seems to be in the bp_get_name_from_root_slug() function. I've attached a patch that seems to work, but would appreciate someone to test this on lots of different combinations of page/component mappings, or feedback from another dev, before commit.

comment:3 boonebgorges23 months ago

I'll have to do some more testing, but I'm guessing it'll be necessary to check *both* the root_slug and slug properties. So a decision will have to be made about order of precedence.

comment:4 DJPaul22 months ago

  • Keywords needs-testing added; has-patch dev-feedback removed

comment:5 DJPaul22 months ago

  • Keywords needs-patch added; needs-testing removed
  • Milestone changed from 1.6 to Future Release

comment:6 DJPaul22 months ago

Moved to a future release as Boone and I don't think we should make this change at this stage of 1.6. As we are already in beta and have no unit test coverage for this, we could break things if we missed a non-obvious case by doing this in a hurry.

comment:7 DJPaul21 months ago

  • Milestone changed from Future Release to 1.7

comment:8 k12onos19 months ago

The patch does not work anymore on 1.6.1. I would really appreciate it if you could update the patch to work on 1.6.1 since 1.7 release will take some time.

jkudish18 months ago

refresh patch, checking both slug and root_slug

comment:9 jkudish18 months ago

  • Cc jkudish added
  • Keywords has-patch added; needs-patch removed

comment:10 boonebgorges18 months ago

  • Keywords needs-testing added

Ugh, this is the kind of thing that's scary to fix without unit tests. At the very least, it'd be nice if someone had the time to do some manual tests with different kinds of nested setups, to make sure that potential slug/root_slug conflicts are detected correctly.

comment:11 jkudish18 months ago

I agree that it needs more testing. FWIW, however, I did test at least a few basic scenarios before submitting the patch :)

comment:12 johnjamesjacoby16 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6616]) Fix bug causing page name/title to be incorrect when directory page has parntes. Props jkudish. Fixes #4242.

Note: See TracTickets for help on using tickets.