bp_forums_get_post_extras(): login and nicename are swapped

[wpdennis]

In function "bp_forums_get_post_extras" the user details are loaded. But login and nicename are swapped:

$posts[$i]->poster_email    = $poster->user_email;
$posts[$i]->poster_login    = $poster->user_nicename;
$posts[$i]->poster_nicename = $poster->user_login;
$posts[$i]->poster_name     = $poster->display_name;

It should be:

$posts[$i]->poster_email    = $poster->user_email;
$posts[$i]->poster_login    = $poster->user_login;
$posts[$i]->poster_nicename = $poster->user_nicename;
$posts[$i]->poster_name     = $poster->display_name;

The function is defined in bp-forums-functions.php:
​http://buddypress.trac.wordpress.org/browser/tags/1.5.4/bp-forums/bp-forums-functions.php#L545

BTW: In function "bp_forums_get_topic_extras" it is set correctly. Please have a look:
​http://buddypress.trac.wordpress.org/browser/tags/1.5.4/bp-forums/bp-forums-functions.php#L404

[boonebgorges]

Confirmed. Good catch.

[boonebgorges]

(In [5918]) Fixes incorrect variable assignment in bp_forums_get_post_extras().
Fixes #4083. Props wpdennis

[boonebgorges]

(In [5919]) Fixes incorrect variable assignment in bp_forums_get_post_extras().
Fixes #4083. Props wpdennis