Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#4084 closed defect (bug) (fixed)

Canonical profile redirect does not allow pretty pagination of default subnav

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: boonebgorges's profile boonebgorges
Milestone: 1.6 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

In bp_redirect_canonical() we should check if there are any action variables before unsetting the 'action' array item from the canonical_stack. This will reenable the ability for default sub navigation to have actionable items.

Better yet, we should probably just whitelist 'page' for now, since no where else in BuddyPress does this appear to be a problem.

Change History (4)

#1 @johnjamesjacoby
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5934]) Whitelist 'page' action variable to prevent bbPress pagination from unsetting the action in the canonical_stack. Fixes #4084.

#2 @boonebgorges
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Good find.

Nowhere in BP do we have a problem with this, but it's at least conceivable that there are other plugins attempting to use semantically relevant action_variables on top of the default nav and subnav. So I believe that, for the moment, we should probably go on the safe side and not pare the defaults off the canonical URL when action_variables are present.

#3 @boonebgorges
13 years ago

  • Owner changed from johnjamesjacoby to boonebgorges
  • Status changed from reopened to assigned

#4 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5990]) When determining canonical URL for items such as groups, don't strip the default extension slug if it's not the last part of the URL. Fixes #4084

Note: See TracTickets for help on using tickets.