XMLRPC error

[lancehudson]

On 1.6 bleeding (5577) getting

<br />
<b>Notice</b>:  Trying to get property of non-object in <b>C:\Development\www\WordPress-Dev\wp-content\plugins\buddypress\bp-core\bp-core-loader.php</b> on line <b>170</b><br />

preventing xml-rpc clients from working. In my case turning off notices isn't an option.

[lancehudson]

Added, patch, feels like a hack though. Anyone know what implications it may have?

[DJPaul]

Or, since we don't expose any of our API via XMLRPC, we could just not load BuddyPress in such situations.

[lancehudson]

I like that better too.

[lancehudson]

Replaces bp-core-loader.php.patch

[lancehudson]

Hows that? I didn't like putting it in the contructor.

[boonebgorges]

I think it'll be easier to keep track of the cases where BP shouldn't load (XML-RPC may not be the only one) if we do it in the constructor.

[boonebgorges]

You know, the more I think about it, the more I'm nervous about simply killing BP on XMLRPC requests. There could be folks out there who are taking advantage of it, even though it's not an official use. (Not sure how, of course, but it's possible that someone has hacked something together.

lancehudson, can you test 3873.03.patch to see if it's enough to fix your problem? It's a much less broad changed.

[lancehudson]

I will test it, few minutes.

[lancehudson]

Works

[boonebgorges]

Gracias amigo :)

[boonebgorges]

(In [5592]) Ensure that bp->loggedin_user->id has a fallback value, for when the current_user global is not available, such as during XML-RPC requests.
Fixes #3873.
Props lancehudson for the initial patch