Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#3835 closed defect (bug) (fixed)

Use WordPress settings API

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

BuddyPress still uses hard-coded settings pages. Everything should be moved over into using the WordPress settings API.

Change History (11)

#1 @johnjamesjacoby
12 years ago

  • Component changed from Core to All Components

#2 @johnjamesjacoby
12 years ago

(In [5508]) Update bp-core-options.php with existing BuddyPress options. See #3835.

#3 follow-up: @boonebgorges
12 years ago

Heads up that the full WP settings API does not work properly with WP Multisite, so we can't use a full implementation. I believe add_settings_section() etc works fine for creating markup, but we have to catch and save settings manually, because the settings api sends form submits to the wrong page (options.php). See #WP15691, #WP18285

#4 in reply to: ↑ 3 @johnjamesjacoby
12 years ago

Replying to boonebgorges:

Heads up that the full WP settings API does not work properly with WP Multisite, so we can't use a full implementation. I believe add_settings_section() etc works fine for creating markup, but we have to catch and save settings manually, because the settings api sends form submits to the wrong page (options.php). See #WP15691, #WP18285

Well that stinks.

#5 @boonebgorges
12 years ago

You're telling me. It's been like this since the Network Admin was introduced. No love for MS :(

#6 @johnjamesjacoby
12 years ago

(In [5524]) First pass at using settings API:

  • Split bp-core-admin.php up into smaller parts
  • Use settings API for Settings screen
  • Backport bbPress 2.x admin class
  • Move admin functions out of core functions and cssjs files
  • Update bp-core-options.php and include
  • Rename menu pages to be more accurate
  • Rename 'Pages' tab to 'Permalinks' for future slugifying
  • See #3835

#7 @DJPaul
12 years ago

  • Milestone changed from Awaiting Review to Future Release

#9 @boonebgorges
11 years ago

  • Milestone Future Release deleted
  • Resolution set to fixed
  • Status changed from new to closed

I'm marking this resolved, as I think we've done as much Settings API conversion as we can safely do, given its shortcomings.

#10 @johnjamesjacoby
9 years ago

  • Component changed from Component - Any/All to API - WordPress

#11 @DJPaul
8 years ago

  • Component changed from API - WordPress to Core
Note: See TracTickets for help on using tickets.