Use WordPress settings API

[johnjamesjacoby]

BuddyPress still uses hard-coded settings pages. Everything should be moved over into using the WordPress settings API.

[johnjamesjacoby]

(In [5508]) Update bp-core-options.php with existing BuddyPress options. See #3835.

[boonebgorges]

Heads up that the full WP settings API does not work properly with WP Multisite, so we can't use a full implementation. I believe add_settings_section() etc works fine for creating markup, but we have to catch and save settings manually, because the settings api sends form submits to the wrong page (options.php). See ​#WP15691, ​#WP18285

[johnjamesjacoby]

Replying to boonebgorges:

Heads up that the full WP settings API does not work properly with WP Multisite, so we can't use a full implementation. I believe add_settings_section() etc works fine for creating markup, but we have to catch and save settings manually, because the settings api sends form submits to the wrong page (options.php). See ​#WP15691, ​#WP18285

Well that stinks.

[boonebgorges]

You're telling me. It's been like this since the Network Admin was introduced. No love for MS :(

[johnjamesjacoby]

(In [5524]) First pass at using settings API:

• Split bp-core-admin.php up into smaller parts
• Use settings API for Settings screen
• Backport bbPress 2.x admin class
• Move admin functions out of core functions and cssjs files
• Update bp-core-options.php and include
• Rename menu pages to be more accurate
• Rename 'Pages' tab to 'Permalinks' for future slugifying
• See #3835

[boonebgorges]

See #3882.

[boonebgorges]

I'm marking this resolved, as I think we've done as much Settings API conversion as we can safely do, given its shortcomings.