#3618 closed defect (bug) (fixed)
UI issue – ”Remove Favorite” title
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 1.5.2 | Priority: | trivial |
Severity: | trivial | Version: | 1.5 |
Component: | Core | Keywords: | ui-feedback |
Cc: |
Description
After marking a item as a “Favorite”, when you hover over “Remove Favorite” the title is the same as “Favorite”. The title being “Mark as Favorite”.
The title should change once marked as favorite.
Change History (6)
#1
@
13 years ago
- Milestone changed from Awaiting Review to 1.5.1
- Priority changed from normal to trivial
- Severity changed from normal to trivial
#3
@
13 years ago
The patch would need to add the localised strings to bp_dtheme_enqueue_scripts()
Strictly speaking, since the AJAX handler just returns the button text, you could use that same text to populate the title attribute. But that seems a bit hackish in a couple ways, so adding separate strings seems better (even if they say the same thing).
Note: See
TracTickets for help on using
tickets.
The javascript that we have for marking/unmarking favorites should be revisited on a broader scale at some point. But, for a bugfix release, we could consider adding a line around 187 in global.js that changes this title text. Patches welcome, otherwise this one's getting booted.