UI issue – ”Remove Favorite” title

[wedeem]

After marking a item as a “Favorite”, when you hover over “Remove Favorite” the title is the same as “Favorite”. The title being “Mark as Favorite”.

The title should change once marked as favorite.

[boonebgorges]

The javascript that we have for marking/unmarking favorites should be revisited on a broader scale at some point. But, for a bugfix release, we could consider adding a line around 187 in global.js that changes this title text. Patches welcome, otherwise this one's getting booted.

[DJPaul]

The patch would need to add the localised strings to bp_dtheme_enqueue_scripts()

[boonebgorges]

The patch would need to add the localised strings to bp_dtheme_enqueue_scripts()

Strictly speaking, since the AJAX handler just returns the button text, you could use that same text to populate the title attribute. But that seems a bit hackish in a couple ways, so adding separate strings seems better (even if they say the same thing).

[boonebgorges]

(In [5362]) Swaps the title attribute on the Favorite/Remove Favorite button when clicked. Fixes #3618

[boonebgorges]

(In [5363]) Swaps the title attribute on the Favorite/Remove Favorite button when clicked. Fixes #3618