Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 3 years ago

#3534 closed defect (bug) (fixed)

Incorrect position of bp_after_group_plugin_template hook

Reported by: Jonnyauk Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

I've noticed an inconsistency in the bp_after_group_plugin_template hook position in:
bp-themes/bp-default/groups/single/plugins.php

In this file:

  • bp_before_group_plugin_template -> inside loop
  • bp_after_group_plugin_template -> outside loop

With the 'before' hook being inside the loop, the 'after' hook should be inside too, as per the structure of:
bp-themes/bp-default/groups/single/home.php

  • bp_before_group_home_content -> inside loop
  • bp_after_group_home_content -> inside loop

Attachments (1)

3534-001-patch.diff (591 bytes) - added by Jonnyauk 8 years ago.

Download all attachments as: .zip

Change History (5)

#1 @boonebgorges
8 years ago

Good catch. These should indeed be in the same place. I happen to think they make more sense outside the loop than inside, but given that in most places they are already inside, we should probably leave them there.

#2 @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5077]) Correct the placement of bp_after_group_plugin_template hook. Fixes #3534. Props Jonnyauk

#3 @boonebgorges
8 years ago

  • Milestone changed from Awaiting Review to 1.5

#4 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.