Skip to:

Opened 13 years ago

Closed 13 years ago

#3363 closed defect (bug) (fixed)

@mentions broken in forum

Reported by: djpaul's profile DJPaul Owned by:
Milestone: 1.5 Priority: major
Severity: normal Version: 1.5
Component: Activity Keywords:


@mentions are broken in forum. They aren't being autolinked, etc.

Attachments (1)

3363.diff (15.0 KB) - added by boonebgorges 13 years ago.

Download all attachments as: .zip

Change History (5)

#1 @DJPaul
13 years ago

And everywhere other than activity stream. On it.

#2 @boonebgorges
13 years ago

As usual, this ended up being more complex to fix than I wanted.

Please see 3363.diff. It reinstates @mention highlighting throughout. I have also reconfigured things so that @-mention notifications (both BP notifications and email notifications) are sent more consistently. The one remaining inconsistency is that notifications are only sent on the portion of the content that appears in the activity item itself. Thus, if you have a very long forum post, for example, with @boonebgorges at the beginning and @djpaul at the end, *both* will be linked, but only @boonebgorges will get a BP/email notification, because the activity contains just an excerpt.

I think this is acceptable, because it's an improvement over the current situation (where you only get notifications when you're mentioned in an update). But I want to get feedback before committing anything.

13 years ago

#3 @DJPaul
13 years ago

  • Severity set to normal

Sounds like a good improvement!

#4 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4738]) Fixes at-mentions so that they are turned into links in contexts other than activity updates. Fixes #3363. Deprecates groups_at_mention_notification() in favor of bp_activity_at_message_notification(). Reconfigures at-mention notification so that BP notifications and email notifications are receieved for a wider variety of activity item types.

Note: See TracTickets for help on using tickets.