Skip to:

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3364 closed defect (bug) (fixed)

Alignment in profile stream

Reported by: xeqta's profile xeqta Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords:


Please see attached screenshot. Some alignment issues on the profile stream.

I suggest aligning all thumbs vertical and maybe change the comment-thumb-size to either the smallest og biggest thumb to stick to 2 different thumb sizes instead of 3.

Attachments (2)

alignment.jpg (152.9 KB) - added by xeqta 13 years ago.
3364-1.patch (5.5 KB) - added by DJPaul 13 years ago.

Download all attachments as: .zip

Change History (17)

13 years ago

#1 @xeqta
13 years ago

Note: Maybe changing the medium size thumb to the biggest size isn't the best idea since the biggest relates to "updates". But the thumbs should be in vertical alignment.

#2 @johnjamesjacoby
13 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Version 1.3 deleted

Moving to 1.3 milestone. Need to figure out some consistent styling here.

#3 follow-up: @boonebgorges
13 years ago

I vote for making the activity comments small, and right-aligning everything.

#4 @r-a-y
13 years ago

If we're thinking of making activity comment avatars the same as mini activity avatars, the same should be done for blog comments.

#5 in reply to: ↑ 3 @johnjamesjacoby
13 years ago

Replying to boonebgorges:

I vote for making the activity comments small, and right-aligning everything.


Activity comments are minor actions.

#6 @DJPaul
13 years ago

  • Component changed from UX/UI to Theme

#7 @boonebgorges
13 years ago

The list of "minor" activity items is in bp_get_activity_css_class(), and is currently:


Shall we add:

#8 @DJPaul
13 years ago

activity_comment are never at the top level of the activity stream; those are of type activity_update. activity_comments already have their own styling.

#9 @DJPaul
13 years ago

Ah, they do on the profile activity stream. I mis-understood the ticket description.

13 years ago

#10 @DJPaul
13 years ago

Please see my first go at this; 3364-1.patch.

My understanding is that BP has 3 avatar sizes; (big) profile avatar, and both a thumbnail-size and a smaller activity stream avatar. BuddyPress has had constants for BP_AVATAR_THUMB_HEIGHT (50px) and BP_AVATAR_FULL_HEIGHT (150px) (width versions too, of course) for a long time. DTheme's CSS has also had hard-coded values for alot of avatars throughout, making these constants pretty rubbish.

I think we need to keep the constants for backpat. Therefore, I've taken out any avatar-related CSS width and height (some of which was referring to a 100px size, which was being overriden by other selectors anyway). I've added a new "tiny" size (small activity stream) version, and put some logic into bp_get_activity_avatar() appropriately.

Last edited 13 years ago by DJPaul (previous) (diff)

#11 @boonebgorges
13 years ago

When avatars are uploaded, BP uses the avatar constants to help build the jQuery cropper, and then to store separate -bpfull and -bpthumb version of the avatar. So while the avatars may be a bit odd, and perhaps unnecessary, for avatar *display*, they are necessary for avatar *creation*.

Your addition of 'tiny' constants makes the code more readable, and it provides a nice shorthand for the tiny avatar 'type', but it does not have its own dedicated -bptiny avatar file. My impression is that it doesn't really need one, since the size difference between tiny and thumb is pretty insignificant for the purposes of resizing and data payload. Second question: if we decide not to have a separate -bptiny avatar stored, do we mind that there is now an asymmetry between the 'full' and 'thumb' avatar types and the 'tiny' type? (I don't think it's really problematic, but it should probably be recognized.)

#12 @DJPaul
13 years ago

I've been thinking about this, and I'm wondering if the tiny avatar could be too specific to DTheme. I'm sure other themes will have their own avatar sizes, so perhaps the current "thumb" and "full" sizes are sufficient. Let's re-work the patch to set the "tiny" size via CSS (from the "thumb" size), as it's a straightforward 50%.

#13 @boonebgorges
13 years ago

That approach sounds wise to me, DJPaul.

#14 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4849]) Align avatars in members' activity streams. Fixes #3364

#15 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.