Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#3252 closed defect (bug) (wontfix)

Reset.css should be updated to version 2.0

Reported by: karmatosed's profile karmatosed Owned by: karmatosed's profile karmatosed
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

http://meyerweb.com/eric/tools/css/reset/ is what we should be using not v1

Attachments (2)

resettwo.diff (1.9 KB) - added by karmatosed 13 years ago.
resettwoback.diff (2.0 KB) - added by karmatosed 13 years ago.

Download all attachments as: .zip

Change History (9)

#1 @r-a-y
13 years ago

I would also propose merging reset.css directly to the top of default.css to reduce a server request.

#2 @karmatosed
13 years ago

There were 2 things that seemed added on top of the version 1.0 reset.css these were:

body {
	background:#fff;
}

a img { border: none; }

These are probably both for backwards compatibility.

I have added 2 patches as a result:

  1. resettwo.diff - without those added
  2. resettwoback.diff - with those added in case keeping them back in is preferred.

@karmatosed
13 years ago

#3 @karmatosed
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#4 @karmatosed
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @DJPaul
13 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

On review of the changes in v2, and discussion with karmatosed on IRC, decided against updating to v2.0 as the additions are mostly HTML5 resets, which doesn't make much sense to include in BP-Default (which isn't HTML5).

r-a-y: I agree. We're probably going to do that. Keep an eye on #3243

#6 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Severity set to normal
  • Version 1.5 deleted

Moving closed ticket out of Awaiting Review.

#7 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.