Skip to:
Content

Opened 8 years ago

Closed 8 years ago

#3183 closed enhancement (fixed)

The Read More functionality

Reported by: Ezd Owned by: DJPaul
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Activity Keywords:
Cc:

Description

Hi,

Just noticed the new Read More button when your posting a long update.

  • On my computer it takes a few seconds for the text to "fold out" right after I click the button. Any chance we could add the loading icon/gif to this action?
  • When the text folds out, is there any way it can do it any smoother? Sometimes it's hacking a bit.

I'm using Safari 5.0.5 by the way. (haven't tested with other browsers)

Change History (10)

#1 @DJPaul
8 years ago

  • Keywords needs-testing added

Does anyone else fancy testing this on a few different browsers? Test against and on http://testbp.org/

#2 @DJPaul
8 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 1.3
  • Version set to 1.3

No problem with adding a spinner but would be interested to investigate this animation speed issue further. How large an update are we talking? A paragraph, lots of paragraphs?

#3 @Ezd
8 years ago

Ok just tested this using Firefox 4. Again, it takes a bit time for the text to fold out and it's not as smooth as it maybe could be. So same behavior as with Safari 5.

(BTW. if I click on the "Load More" button on the activity stream, find a long update with the "Read More" button, it jumps to the perma-link page when I click it instead of just showing the text". Just not sure if you guys are aware of that. :-))

#4 @DJPaul
8 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#5 @djpaul
8 years ago

(In [4305]) Added AJAX loading spinner to activity stream 'read more' link. See #3183

#6 @DJPaul
8 years ago

  • Keywords reporter-feedback added; needs-testing needs-patch removed

Ezd, I've added a loading spinner for the AJAX call. I've slowed down the animation fractionally, but I tested against Safari 5, Firefox 2 & 4, Chrome 11, Opera 11.10 (all on Mac) and IE9 (Windows 7) with a very large text sample. I couldn't recreate any significant slowdown. Can you update your install and test the new spinner please?

#7 @Ezd
8 years ago

Hi Paul, can I test it on testbp.org? I'm currently unable to test on my own installation due to some server changes. If not, perhaps someone else can test out the new changes..?

#8 @ezd
8 years ago

Ok just tested this and it's much better now, especially with the spinner. I think a slow down on the ajax effect helped a bit too.

#9 @ezd
8 years ago

  • Keywords reporter-feedback removed

#10 @DJPaul
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Excellent, thanks for testing. Closing the ticket as fixed.

Note: See TracTickets for help on using tickets.