Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#3184 closed enhancement (fixed)

deprecate bp_core_add_admin_menu_page()?

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

BuddyPress has long had bp_core_add_admin_menu_page(), its own version of add_admin_menu_page(), because "[it] allows [better] positioning of menus."

However, I'm looking at add_menu_page() and it seems to have a parameter to let us position the menu where we want, and the rest of the code looks pretty similar. Could someone check? I'd like to deprecate bp_core_add_admin_menu_page() and call add_admin_menu_page() instead.

Of course, if add_admin_menu_page() does miss something we find useful, we can send a patch upstream.

Change History (2)

#1 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Owner set to DJPaul
  • Status changed from new to assigned

#2 @djpaul
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4309]) Deprecate bp_core_add_admin_menu_page() in favour of add_menu_page(). Fixes #3184

Note: See TracTickets for help on using tickets.