Skip to:

Opened 13 years ago

Last modified 11 years ago

#3099 new defect (bug)

Unhide activity for an unmarked spammer

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 1.5
Component: Activity Keywords:


When you accidentally mark a user as a spammer and you need to unmark said user, the user's activity is hidden because of hide_sitewide = 1.

I've attached a patch for this, but it needs additional work as when I was writing the patch I did not take into consideration of a group's privacy settings.

I just set all of the user's activity back to hide_sitewide = 0.

Attachments (1)

3099.01.patch (1.9 KB) - added by r-a-y 13 years ago.

Download all attachments as: .zip

Change History (6)

13 years ago

#1 @DJPaul
13 years ago

  • Keywords dev-feedback added

You're correct that the patch would need to check what the value of hide_sitewide should be, but it comes up in more cases than just when dealing with a group. The problem is hide_sitewide has grown in scope and is used for multiple things. This has been discussed in dev chats and I think on another ticket somewhere, which I can't find.

I'm not sure if the best fix is to sort out the hide_sitewide problem for 1.3 or put something like this patch in for the time being.

#2 @r-a-y
13 years ago

Is this the other ticket you're speaking of?

#3 @DJPaul
13 years ago

Good find

#4 @DJPaul
13 years ago

  • Milestone changed from Awaiting Review to Future Release

#5 @DJPaul
11 years ago

  • Keywords has-patch needs-patch dev-feedback removed
  • Severity set to normal

Maybe we should think about the hide_sitewide mess in 1.9.

Note: See TracTickets for help on using tickets.