Unhide activity for an unmarked spammer

[r-a-y]

When you accidentally mark a user as a spammer and you need to unmark said user, the user's activity is hidden because of hide_sitewide = 1.

I've attached a patch for this, but it needs additional work as when I was writing the patch I did not take into consideration of a group's privacy settings.

I just set all of the user's activity back to hide_sitewide = 0.

[DJPaul]

You're correct that the patch would need to check what the value of hide_sitewide should be, but it comes up in more cases than just when dealing with a group. The problem is hide_sitewide has grown in scope and is used for multiple things. This has been discussed in dev chats and I think on another ticket somewhere, which I can't find.

I'm not sure if the best fix is to sort out the hide_sitewide problem for 1.3 or put something like this patch in for the time being.

[r-a-y]

Is this the other ticket you're speaking of?
​http://trac.buddypress.org/ticket/2293#comment:10

[DJPaul]

Good find

[DJPaul]

Maybe we should think about the hide_sitewide mess in 1.9.