Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 12 years ago

#3100 closed defect (bug) (duplicate)

"bp-members" do_actions issue

Reported by: r-a-y's profile r-a-y Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.5 Priority: major
Severity: Version: 1.5
Component: Core Keywords: dev-feedback
Cc:

Description

During the refactoring of "bp-core" to "bp-members", all member do_actions were renamed to "bp_members_x" from "bp_core_x".

Plugins that used these do_actions will no longer work in BP 1.3.

---

Should these actions be renamed back to "bp_core_x"?

Or should we just add an additional do_action for "bp_core_x"?

eg.

// Deprecated do_action
do_action( 'bp_core_action_set_spammer_status', $bp->displayed_user->id, $is_spam );

do_action( 'bp_members_action_set_spammer_status', $bp->displayed_user->id, $is_spam );

Or are plugin developers encouraged to update their hooks for BP 1.3?

Change History (3)

#1 @DJPaul
13 years ago

See what John said on http://bpdevel.wordpress.com/2011/01/20/running-an-audit-on-all-files-in-the-nex/. Personally I would like these actions invoked with their new names and their old names, and deprecate the old in a later version.

#2 @DJPaul
12 years ago

  • Milestone changed from Awaiting Review to 1.3
  • Owner set to johnjamesjacoby
  • Priority changed from normal to major
  • Status changed from new to assigned

#3 @boonebgorges
12 years ago

  • Resolution set to duplicate
  • Status changed from assigned to closed

I appear to have opened a duplicate ticket with #3158. I'm going to close this ticket in favor of that one, as there is more discussion happening there.

Note: See TracTickets for help on using tickets.