Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3035 closed defect (bug) (no action required)

php notices after applying patch

Reported by: jasonnathan Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Happened after applying patch that fixes 3033

Notice: Undefined index: title in wp31\wp-content\plugins\buddypress\bp-core\bp-core-widgets.php on line 149

Notice: Undefined index: max_members in wp31\wp-content\plugins\buddypress\bp-core\bp-core-widgets.php on line 152

Notice: Undefined property: stdClass::$forums in wp31\wp-content\plugins\buddypress\bp-core\bp-core-filters.php on line 19

Change History (8)

#1 @jasonnathan
8 years ago

The last notice is because I disabled forums

#2 @DJPaul
8 years ago

What version of BuddyPress are you using

#3 @jasonnathan
8 years ago

The latest bleeding version. Downloaded via svn. After the patch for the widgets were applied, I did a svn update to revision and found these new notices.

#4 @jasonnathan
8 years ago

I managed to get rid of the first few notices by setting a title in the widget (Who's online avatars). However, the widget "Pages" still throws an error about the forums. I have it disabled.

#5 @jasonnathan
8 years ago

Okay I found the problem in bp_core_exclude_pages() in bp-core-filters.php

if ( !bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && !bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id;

The condition is checking if the forums isn't active. Shouldn't it be checking is it is active?

if ( bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id;

#6 @jasonnathan
8 years ago

Correction, should be

if ( !bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id

;

#7 @DJPaul
8 years ago

  • Resolution set to invalid
  • Status changed from new to closed

These are fixed in the trunk

#8 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Severity set to normal

Moving closed ticket out of Awaiting Review.

Note: See TracTickets for help on using tickets.