php notices after applying patch

[jasonnathan]

Happened after applying patch that fixes 3033

Notice: Undefined index: title in wp31\wp-content\plugins\buddypress\bp-core\bp-core-widgets.php on line 149

Notice: Undefined index: max_members in wp31\wp-content\plugins\buddypress\bp-core\bp-core-widgets.php on line 152

Notice: Undefined property: stdClass::$forums in wp31\wp-content\plugins\buddypress\bp-core\bp-core-filters.php on line 19

[jasonnathan]

The last notice is because I disabled forums

[DJPaul]

What version of BuddyPress are you using

[jasonnathan]

The latest bleeding version. Downloaded via svn. After the patch for the widgets were applied, I did a svn update to revision and found these new notices.

[jasonnathan]

I managed to get rid of the first few notices by setting a title in the widget (Who's online avatars). However, the widget "Pages" still throws an error about the forums. I have it disabled.

[jasonnathan]

Okay I found the problem in bp_core_exclude_pages() in bp-core-filters.php

if ( !bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && !bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id;

The condition is checking if the forums isn't active. Shouldn't it be checking is it is active?

if ( bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id;

[jasonnathan]

Correction, should be

if ( !bp_is_active( 'forums' ) || ( function_exists( 'bp_forums_is_installed_correctly' ) && bp_forums_is_installed_correctly() ) )
		$pages[] = $bp->pages->forums->id

;

[DJPaul]

These are fixed in the trunk

[johnjamesjacoby]

Moving closed ticket out of Awaiting Review.