Skip to:
Content

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3034 closed enhancement (wontfix)

Groups Slug should be used for the search field defined in groups component

Reported by: jasonnathan Owned by:
Milestone: 1.5 Priority: normal
Severity: normal Version:
Component: Groups Keywords:
Cc:

Description

Since BP_GROUPS_SLUG is still operative, shouldn't line 79 in bp-groups-loader.php's _setup_globals() function be changed from:

'search_string'         => __( 'Search Groups...', 'buddypress' ),

to something more like

'search_string'         => __( 'Search ' . ucfirst(BP_GROUPS_SLUG ) . '...', 'buddypress' ),
}}}?

Haven't checked the other components. Will update when I do.

Change History (3)

#1 @jasonnathan
8 years ago

Okay, the reason I submitted the ticket was because I was under the impression that all other references to such slugs were in template files.

So I'll just have to use a language file instead.

However, after perusing the components, I noticed all similar references in every component is either the singular or plural version of the the COMPONENT_SLUG constant.

Wouldn't implementing a singular/plural definition in the each component's loader file be much more Wordpress-like (with reference to custom post types).

Eliminates the need to create a language file. I could come up with patches, but don't know if this is feasible.

#2 @DJPaul
8 years ago

  • Resolution set to wontfix
  • Status changed from new to closed
  • Type changed from defect to enhancement

I doubt it is possible to make one singular and one plural definition of a component name and be able to use it correctly in every circumstance, and have it be correct per grammar rules of whichever language is being used. This is best left to i18n and friends, as is being done currently.

#3 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 1.5
  • Severity set to normal

Moving closed ticket out of Awaiting Review.

Note: See TracTickets for help on using tickets.