Skip to:
Content

BuddyPress.org

Opened 16 years ago

Closed 16 years ago

#2997 closed defect (bug) (fixed)

wp-includes/registration.php is deprecated in WP 3.1

Reported by: DJPaul Owned by: nacin
Priority: normal Milestone: 1.5
Component: Core Version:
Severity: Keywords: has-patch
Cc:

Description

Create a wrapper function to retain compatibility with 3.0.

Attachments (1)

2997.diff​ (4.0 KB ) - added by nacin 16 years ago.

Download all attachments as: .zip

Change History (7)

#1 @djpaul
16 years ago

  • Resolution → fixed
  • Status new → closed

(In [3661]) Don't include wp-includes/registration.php if on WordPress 3.1. Fixes #2997

#2 @nacin
16 years ago

  • Resolution fixed
  • Status closed → reopened

Going to supply an alternative patch for this.

#3 @nacin
16 years ago

  • Owner set to nacin
  • Status reopened → accepted

#4 @nacin
16 years ago

  • Keywords has-patch added

Two problems: One, this doesn't work, due to the lack of version_compare. Two, it's better to do feature detection (which you can later just drop when you drop support for 3.0). Three, after searching for registration.php functions, I found places that registration.php was being included apparently unnecessarily. Patch attached. Needs a test, as I'm doing this without an install of BuddyPress trunk actually active.

@nacin
16 years ago

#5 @boonebgorges
16 years ago

+1 on feature detection over an extra function. Patch is mostly good, though there was one necessary require that got deleted somewhere along the way (fired at account activation).

#6 @boonebgorges
16 years ago

  • Resolution → fixed
  • Status accepted → closed

(In [3666]) Refactors registration.php requires so they don't require an additional function. Fixes #2997. Props nacin

Note: See TracTickets for help on using tickets.