Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2724 closed enhancement (fixed)

bp_thread_has_messages order

Reported by: aesqe's profile aesqe Owned by:
Milestone: 1.5 Priority: normal
Severity: Version: 1.5
Component: Messages Keywords: private messages, order, has-patch
Cc: aesqe

Description

Here's a patch that allows the order of private messages in a thread to be set as either ASC or DESC via bp_thread_has_messages() args.

I guess someone started working on this and never got around to finishing it, because everything was pretty much already in place, just the $order variable was missing in a few places.

Attachments (1)

bp-messages-order.patch​ (102.8 KB) - added by aesqe 14 years ago.

Download all attachments as: .zip

Change History (6)

#1 @aesqe
14 years ago

ok, it's not that simple after all, needs a javascript patch too. i'll take a deeper look, sorry for this.

#2 @aesqe
14 years ago

  • Cc aesqe added
  • Keywords has-patch added

here's the complete patch, it works as expected, and i hope that my way of implementing it conforms to buddypress standards.

also, sorry for the huge patch file, really don't know why tortoise included two whole files :/

@aesqe
14 years ago

#3 @aesqe
14 years ago

changes in global.js file are from lines 837 to 885, and the only change in the single.php file is the inserted line 84

#4 @boonebgorges
14 years ago

Nice patch - thanks, aesqe!

#5 @boonebgorges
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3384]) Allows private message thread ordering. Fixes #2724. Props aesqe

Note: See TracTickets for help on using tickets.