Skip to:
Content

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#2661 closed defect (bug) (fixed)

Ban & Kick user is broken.

Reported by: yakster Owned by: DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Groups Keywords: has-patch
Cc:

Description

When I go click on the ban & kick user saying "There was an error banning that user. Please try again. If I try again same error. I can still log back in as that user. I have put together some screen shots. I disabled all my plugins and still the same issue. This would appear to be a bug in buddypress. I really need this to work before I launch my site. Do you have a work around or fix?

Thanks,

Yak

Attachments (3)

error.png (82.7 KB) - added by yakster 4 years ago.
Screen shots of error.
2661.001.patch (3.4 KB) - added by r-a-y 3 years ago.
2661.002.patch (3.4 KB) - added by r-a-y 3 years ago.
Fixes file path from previous patch

Download all attachments as: .zip

Change History (14)

yakster4 years ago

Screen shots of error.

comment:1 r-a-y3 years ago

  • Keywords reporter-feedback close added

Have you upgraded BuddyPress to the latest version to see if this issue still happens on your install?

Just tried kicking and banning a user from a group on WP 3.0 and BP 1.2.6 and it works for me.

comment:2 boonebgorges3 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

Works for me too. Could be a plugin or theme conflict. Upgrade (as r-a-y suggests), deactivate all plugins but BP, switch to the BuddyPress default theme, and try again. If it still doesn't work, please reopen this ticket.

comment:3 r-a-y3 years ago

  • Keywords needs-patch added; reporter-feedback close removed
  • Resolution worksforme deleted
  • Status changed from closed to reopened

Just re-read the OP's report.

Problem exists. Kick and ban a user, then login as banned user and attempt to post in a forum.

You are able to because the forum post form still shows up. Need to patch it so the forum post form doesn't show up if the user is banned.

The banned user can also see the "Join Group" button after they're banned.

Patch on the way!

r-a-y3 years ago

comment:4 r-a-y3 years ago

  • Component changed from Core to Groups
  • Keywords has-patch added; needs-patch removed

Needed to create a new function to check if a user is banned from a group, since bp_group_member_is_banned() is only applicable to the group member loop.

comment:5 r-a-y3 years ago

Forgot to mention that patch is against v1.2.6. Sorry about that!

r-a-y3 years ago

Fixes file path from previous patch

comment:6 r-a-y3 years ago

Just noticed that the original report is missing many details.

Full thread is here:
http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/ban-and-kick-user-is-broken/

comment:7 DJPaul3 years ago

  • Owner set to DJPaul
  • Status changed from reopened to assigned

comment:8 djpaul3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3537]) Prevent banned group users posting new topics, and re-joining groups. Fixes #2661 and #2957, props r-a-y for initial patch.

comment:9 r-a-y3 years ago

Paul, on line 1032 in trunk/bp-groups/bp-groups-templatetags.php, shouldn't it return false instead of true?
http://trac.buddypress.org/browser/trunk/bp-groups/bp-groups-templatetags.php#L1032

Super admin shouldn't be banned right ;)

comment:10 djpaul3 years ago

(In [3538]) Don't ban super admins! Fixes mistake introduced in r3537, see #2661. Props r-a-y

comment:11 djpaul3 years ago

(In [3540]) Revert part of r3537 to fix group admins/mods display. See #2661.

Note: See TracTickets for help on using tickets.