Inconsistent avatar sizes in activity stream

[DJPaul]

Per the attached screenshot of ​http://testbp.org/activity, I've annotated what I consider to be a defect with regards to inconsistent image sizes on this page. It's best to look at the "scaled to" sizes as the original images for some parts, such as members' avatars, can be all sorts of sizes.

Internally, BuddyPress has the following constants for avatar sizes: BP_AVATAR_THUMB_HEIGHT (50px), BP_AVATAR_FULL_WIDTH (150px).

I believe the default theme needs to be more consistent its image sizes.

[DJPaul]

Image uploaded to ​http://byotos.com/?attachment_id=321 as I hit the file size restriction here.

[DJPaul]

v1

[DJPaul]

Patch changes the identified 25px images to 20px, which better matches the line height (which is why I assume most of the images were 20px). It also changes the large activity avatar & "what's new" avatars from 60px to BP_AVATAR_THUMB_WIDTH/HEIGHT (50px), to match the size of the avatars on the Groups and Members directories. I'm using the constant to allow customisation of that to propagate more through the site.

[johnjamesjacoby]

(In [3287]) Fixes #2662 (branch) props PaulGibbs

[DJPaul]

Per http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/ver-1-2-6-issue-in-cssgraphic-avatar-sizing-in-reply-to-activity-stream/#post-76423, the "reply to" avatar generated by the AJAX button was missed.

[johnjamesjacoby]

These were left out intentionally as they broke single stream view. Can obviously revisit for 1.3 though.

[pisanojm]

If patch wasn't included... then something else must be doing that to the avatar size in the reply...

[r-a-y]

Just checked out the activity form avatar locally (on BP 1.2.6) and on testbp.org.
Looks correct to me.

Isn't 50x50 the right size? I'm actually a fan of the larger avatar instead of the 20x20.

[boonebgorges]

Looks fine to me on the trunk. I'm not seeing how the left-out arguments in ajax.php from Paul's original patch make any difference, at least on my installations.