Skip to:
Content

Opened 4 years ago

Closed 3 years ago

#2662 closed defect (bug) (fixed)

Inconsistent avatar sizes in activity stream

Reported by: DJPaul Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Activity Keywords: 2nd-opinion close
Cc:

Description

Per the attached screenshot of http://testbp.org/activity, I've annotated what I consider to be a defect with regards to inconsistent image sizes on this page. It's best to look at the "scaled to" sizes as the original images for some parts, such as members' avatars, can be all sorts of sizes.

Internally, BuddyPress has the following constants for avatar sizes: BP_AVATAR_THUMB_HEIGHT (50px), BP_AVATAR_FULL_WIDTH (150px).

I believe the default theme needs to be more consistent its image sizes.

Attachments (1)

turtlebread.patch (4.3 KB) - added by DJPaul 4 years ago.
v1

Download all attachments as: .zip

Change History (10)

comment:1 DJPaul4 years ago

Image uploaded to http://byotos.com/?attachment_id=321 as I hit the file size restriction here.

DJPaul4 years ago

v1

comment:2 DJPaul4 years ago

Patch changes the identified 25px images to 20px, which better matches the line height (which is why I assume most of the images were 20px). It also changes the large activity avatar & "what's new" avatars from 60px to BP_AVATAR_THUMB_WIDTH/HEIGHT (50px), to match the size of the avatars on the Groups and Members directories. I'm using the constant to allow customisation of that to propagate more through the site.

comment:3 paulhastings04 years ago

  • Summary changed from inconsistent image sizes in activity stream to [patch] Inconsistent image sizes in activity stream

comment:4 johnjamesjacoby4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3287]) Fixes #2662 (branch) props PaulGibbs

comment:5 DJPaul3 years ago

  • Milestone changed from 1.2.6 to 1.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:6 johnjamesjacoby3 years ago

These were left out intentionally as they broke single stream view. Can obviously revisit for 1.3 though.

comment:7 pisanojm3 years ago

If patch wasn't included... then something else must be doing that to the avatar size in the reply...

comment:8 r-a-y3 years ago

  • Keywords 2nd-opinion close added
  • Summary changed from [patch] Inconsistent image sizes in activity stream to Inconsistent avatar sizes in activity stream

Just checked out the activity form avatar locally (on BP 1.2.6) and on testbp.org.
Looks correct to me.

Isn't 50x50 the right size? I'm actually a fan of the larger avatar instead of the 20x20.

comment:9 boonebgorges3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Looks fine to me on the trunk. I'm not seeing how the left-out arguments in ajax.php from Paul's original patch make any difference, at least on my installations.

Note: See TracTickets for help on using tickets.