Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#2511 closed defect (bug) (fixed)

[patch] bp_your_or_their misses parameters

Reported by: francescolaffi's profile francescolaffi Owned by:
Milestone: 1.5 Priority: trivial
Severity: Version:
Component: Core Keywords: dev-feedback has-patch
Cc:

Description

function bp_your_or_their - bp-core/bp-core-templatetags.php:873 doesn't have parameters $yourtext and $theirtext, it's pretty useless without them

solution:

function bp_your_or_their( $yourtext, $theirtext, $capitalize = true, $echo = true )

Attachments (1)

2511.001.diff (432 bytes) - added by cnorris23 12 years ago.

Download all attachments as: .zip

Change History (9)

#1 @francescolaffi
12 years ago

  • Keywords dev-feedback has-patch added

@cnorris23
12 years ago

#2 @cnorris23
12 years ago

adding a patch file to make it a little easier

#3 follow-up: @r-a-y
12 years ago

Patch needs to be changed, because if the bp_your_or_their() function is used elsewhere in the code or a plugin, it will break.

Add the new variables at the end, instead of the beginning.

#4 in reply to: ↑ 3 @francescolaffi
12 years ago

Replying to r-a-y:

Patch needs to be changed, because if the bp_your_or_their() function is used elsewhere in the code or a plugin, it will break.

Add the new variables at the end, instead of the beginning.

right now the function can't be used at all because of the missing args and with this order is consistent with similar funcs (like your_or_name).
what you say is generally correct but I don't think it applies in this case

#5 @johnjamesjacoby
12 years ago

  • Milestone changed from 1.2.6 to 1.3
  • Priority changed from minor to trivial

Moved to 1.3 and changed to trivial. This function isn't used anywhere in BuddyPress anymore, and should be moved into the backpat plugin.

#6 @paulhastings0
12 years ago

  • Summary changed from bp_your_or_their misses parameters to [patch] bp_your_or_their misses parameters

#7 @DJPaul
12 years ago

Are we moving all 1.0/1.1 era stuff to the backwards compatibility plugin, or are we marking with _deprecated_function()?

#8 @djpaul
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3329]) Remove obsolete function, last used in pre-1.0rc2. Fixes #2511.

Note: See TracTickets for help on using tickets.