[patch] bp_your_or_their misses parameters

[francescolaffi]

function bp_your_or_their - bp-core/bp-core-templatetags.php:873 doesn't have parameters $yourtext and $theirtext, it's pretty useless without them

solution:

function bp_your_or_their( $yourtext, $theirtext, $capitalize = true, $echo = true )

[cnorris23]

adding a patch file to make it a little easier

[r-a-y]

Patch needs to be changed, because if the bp_your_or_their() function is used elsewhere in the code or a plugin, it will break.

Add the new variables at the end, instead of the beginning.

[francescolaffi]

Replying to r-a-y:

Patch needs to be changed, because if the bp_your_or_their() function is used elsewhere in the code or a plugin, it will break.

Add the new variables at the end, instead of the beginning.

right now the function can't be used at all because of the missing args and with this order is consistent with similar funcs (like your_or_name).
what you say is generally correct but I don't think it applies in this case

[johnjamesjacoby]

Moved to 1.3 and changed to trivial. This function isn't used anywhere in BuddyPress anymore, and should be moved into the backpat plugin.

[DJPaul]

Are we moving all 1.0/1.1 era stuff to the backwards compatibility plugin, or are we marking with _deprecated_function()?

[djpaul]

(In [3329]) Remove obsolete function, last used in pre-1.0rc2. Fixes #2511.