Skip to:

Opened 14 years ago

Closed 14 years ago

#2231 closed defect (bug) (fixed)

Activity Stream Loop comments broken

Reported by: abfinteractive's profile abfinteractive Owned by:
Milestone: 1.5 Priority: minor
Severity: Version:
Component: Activity Keywords: reporter-feedback


See this:

We have the activity loop showing on our main page here:

The activity loop works but enabling threaded comments does not work using that code provided.

You can test this on our site by registering and trying to comment on an activity while on the domain root. Once you click to reply to an activity the page just reloads with the url.

I do not know if this is a bug with that code on the developers page or issues with the function but it does not work on our site.

Attachments (1)

activity.txt (3.4 KB) - added by abfinteractive 14 years ago.
code that is inserted into index.php

Download all attachments as: .zip

Change History (8)

#1 @cnorris23
14 years ago

  • Keywords reporter-feedback added

What version of BP are you running? You appear to be using a customized version of the new default theme, so I'm assuming your running 1.2.x. If this is the case, you should have threaded comments by default. I see that if you go the activity page, threaded comments are working.

#2 @abfinteractive
14 years ago

Yes they are working on the activity page but the code to have them displayed on the homepage is not working. Using 1.2.3.

#3 @cnorris23
14 years ago

Could you post the loop code to a txt file and attach it to the ticket, or post it to something like pastebin? I'll see if I can help you troubleshoot. Like the site by the way :).

#4 @cnorris23
14 years ago

Also, how are you getting the comments on the main page? Are you using a BP page, and setting it as the main page through the Settings > Reading in the dashboard, or are you going about it another way?

14 years ago

code that is inserted into index.php

#5 @abfinteractive
14 years ago

I insert the code into index.php listed on the page in the original ticket post. This shows the activity correctly but replying within index.php does not work.

#6 @cnorris23
14 years ago

Perfect. That helped a lot, and I have a fix. I tested this on my local install, using your exact code you posted above. As with your custom theme it didn't work. My suspicion was that it had something to do with the ajax/jquery, and this suspicion seems to be correct. In order for the comment form to be shown, it goes through a series of jQuery HTML class checks. In your case, the issue, is here:

<div class="home_activity">
<h3>Latest Activity</h3>

The jQuery code expects:

<div class="activity">
<h3>Latest Activity</h3>

If you need home_activity for some home page activity specific styling, then I suggest the following:

<div class="activity home_activity">
<h3>Latest Activity</h3>

This way you get the best of both worlds. Hopefully, this will fix your issue. Let me know, if that's not the case.

#7 @abfinteractive
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This has fixed it now. Thanks for your help!

Note: See TracTickets for help on using tickets.