Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 9 years ago

#2073 closed defect (bug) (fixed)

Wrong redirection on login when redirect_to is defined

Reported by: francescolaffi Owned by:
Milestone: 1.5 Priority: major
Severity: normal Version:
Component: Core Keywords: reporter-feedback
Cc: francescolaffi

Description

I found that when in the login request is present the redirect_to address, buddypress redirect to homepage if 'wp-admin' is not in the address, shuldn't it do the opposite?

in bp-core.php in the function bp_core_login_redirect i think that this line (2106)

if ( !empty( $_REQUEST['redirect_to'] ) && strpos( $_REQUEST['redirect_to'], 'wp-admin' ) )

should be

if ( !empty( $_REQUEST['redirect_to'] ) && false === strpos( $_REQUEST['redirect_to'], 'wp-admin' ) )

P.S.: sorry if i did something wrong, it's the first time i use a bug tracking system

Change History (4)

#1 @francescolaffi
11 years ago

  • Cc francescolaffi added

#2 @cnorris23
10 years ago

  • Component set to Core
  • Keywords reporter-feedback added; login redirect removed

Is this still an issue? Glancing at the code, it looks as if this is correct.

#3 @boonebgorges
9 years ago

  • Milestone set to 1.5
  • Severity set to normal

#4 @boonebgorges
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4898]) Ensures that bp_core_login_redirect() successfully directs users away from wp-admin. Fixes #2073. Props francescolaffi

Note: See TracTickets for help on using tickets.