Wrong number of group members

[SickSight]

The counter for Group Members at this Group:
​http://testbp.org/groups/the-germans-are-taking-over-buddypress/members/

[r-a-y]

Could be a person marked as a spammer that's causing the member count to be askew?

[helpy]

I have a similar problem! A user was deleted, but the member count in the groups are not updated!

On /groups/[group-name]/members/ the tab "members (member count)" shows the wrong memeber count. But the text "Viewing members 1 to X (of Y members)" shows the right member count!

[r-a-y]

Is this still valid? There were some fixes for this in BP 1.2.5.

[boonebgorges]

I just did some tests against the latest trunk: 1) deleting users as the admin, 2) users self-deleting, 3) marking users as spammers. (1) and (2) adjust the member count correctly. (3) does not.

After some tracing through mark-as-spam routine, I noticed that the make_spam_user hook (which triggers the BP data deletion process) only exists if you've got MU/MS activated. So on single installations, marking a user as spam didn't delete data.

I'm committing a patch that fixes this with a custom hook. I'll mark this ticket as fixed, under the assumption that this does fix the problem. Please reopen the ticket if the problem still arises.

[boonebgorges]

(In [3434]) Fires custom BP hook when user is marked as spam, in order to account for instances where Network is not enabled. Fixes #1975