Skip to:
Content

BuddyPress.org

Opened 17 years ago

Closed 17 years ago

Last modified 15 years ago

#1708 closed enhancement (fixed)

The ajax action for activity post updates should not have hard coded groups code HAS-PATCH

Reported by: MrMaz Owned by: apeatling
Priority: major Milestone: 1.2
Component: Core Version:
Severity: normal Keywords: has-patch
Cc:

Description

Per conversation with JJJ, the activity "post_update" ajax action should be made more generic so that plugin developers can reuse this action for their own custom activity post boxes.

Here are the two sides of it:

​http://trac.buddypress.org/browser/trunk/bp-themes/bp-default/_inc/global.js#L47
​http://trac.buddypress.org/browser/trunk/bp-themes/bp-default/_inc/ajax.php#L55

Attachments (3)

activity-allow-custom-post-action.patch​ (2.2 KB ) - added by johnjamesjacoby 17 years ago.
Just dance, do do do, just dance
extensible_activity_posts.patch​ (2.7 KB ) - added by MrMaz 17 years ago.
extensible_activity_posts_2.patch​ (2.8 KB ) - added by MrMaz 17 years ago.
Minor correction to my first patch

Download all attachments as: .zip

Change History (9)

@johnjamesjacoby
17 years ago

Just dance, do do do, just dance

#1 follow-up: @MrMaz
17 years ago

  • Owner set to apeatling
  • Priority minor → major
  • Status new → assigned

Attaching my patch which goes a step further than JJJ's to make it a purely extensible action.

@MrMaz
17 years ago

@MrMaz
17 years ago

Minor correction to my first patch

#2 @MrMaz
17 years ago

  • Keywords has-patch added

#3 @MrMaz
17 years ago

  • Summary The ajax action for activity post updates should not have hard coded groups code → The ajax action for activity post updates should not have hard coded groups code HAS-PATCH

#4 @apeatling
17 years ago

This patch breaks posting to a group on the activity page.

#5 @apeatling
17 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [2552]) Fixes #1708 - more extensible posting.

#6 in reply to: ↑ 1 @jafar1374
15 years ago

  • Component → Core
  • Severity → normal

Replying to MrMaz:

Attaching my patch which goes a step further than JJJ's to make it a purely extensible action.

Pleas help me how can i use this Ticket : the activity "post_update" ajax action?

Note: See TracTickets for help on using tickets.