Skip to:
Content

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#1708 closed enhancement (fixed)

The ajax action for activity post updates should not have hard coded groups code HAS-PATCH

Reported by: MrMaz Owned by: apeatling
Milestone: 1.2 Priority: major
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

Per conversation with JJJ, the activity "post_update" ajax action should be made more generic so that plugin developers can reuse this action for their own custom activity post boxes.

Here are the two sides of it:

http://trac.buddypress.org/browser/trunk/bp-themes/bp-default/_inc/global.js#L47
http://trac.buddypress.org/browser/trunk/bp-themes/bp-default/_inc/ajax.php#L55

Attachments (3)

activity-allow-custom-post-action.patch (2.2 KB) - added by johnjamesjacoby 9 years ago.
Just dance, do do do, just dance
extensible_activity_posts.patch (2.7 KB) - added by MrMaz 9 years ago.
extensible_activity_posts_2.patch (2.8 KB) - added by MrMaz 9 years ago.
Minor correction to my first patch

Download all attachments as: .zip

Change History (9)

@johnjamesjacoby
9 years ago

Just dance, do do do, just dance

#1 follow-up: @MrMaz
9 years ago

  • Owner set to apeatling
  • Priority changed from minor to major
  • Status changed from new to assigned

Attaching my patch which goes a step further than JJJ's to make it a purely extensible action.

@MrMaz
9 years ago

Minor correction to my first patch

#2 @MrMaz
9 years ago

  • Keywords has-patch added

#3 @MrMaz
9 years ago

  • Summary changed from The ajax action for activity post updates should not have hard coded groups code to The ajax action for activity post updates should not have hard coded groups code HAS-PATCH

#4 @apeatling
9 years ago

This patch breaks posting to a group on the activity page.

#5 @apeatling
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2552]) Fixes #1708 - more extensible posting.

#6 in reply to: ↑ 1 @jafar1374
8 years ago

  • Component set to Core
  • Severity set to normal

Replying to MrMaz:

Attaching my patch which goes a step further than JJJ's to make it a purely extensible action.

Pleas help me how can i use this Ticket : the activity "post_update" ajax action?

Note: See TracTickets for help on using tickets.