Skip to:
Content

Opened 5 years ago

Closed 3 years ago

#1134 closed defect (bug) (wontfix)

[patch] IE 7 renders sign up button incorrectly [Has patch]

Reported by: enailor Owned by: DJPaul
Milestone: 1.5 Priority: trivial
Severity: Version:
Component: Core Keywords: button, IE
Cc: Jason_JM

Description

Using BP1.1 Default theme and viewing using IE 7, the sign up button renders incorrectly. I have attached a screenshot for those not using IE. Not sure if this is an issue in all IE browsers.

Attachments (2)

ie7-button-issue.png (138.9 KB) - added by enailor 5 years ago.
Screenshot of IE 7 Button issue
components.css.patch (626 bytes) - added by r-a-y 5 years ago.
Tentative patch for IE7/6

Download all attachments as: .zip

Change History (21)

enailor5 years ago

Screenshot of IE 7 Button issue

comment:1 enailor5 years ago

  • Milestone 1.1.1 deleted

comment:2 Jason_JM5 years ago

Hot Dang thats a big button!

comment:3 apeatling5 years ago

  • Priority changed from major to minor

No CSS support for display: inline-block in IE7, upgrade to IE8, or if someone wants to write a patch, by all means please do.

r-a-y5 years ago

Tentative patch for IE7/6

comment:4 r-a-y5 years ago

I encountered this issue awhile back, but remedied it with a CSS override targeting IE7 (and IE6).

I have a body CSS class which detected what browser is running and then overrided the .generic-button class.

eg.

.ie7 .generic-button {display:inline;}

But since the default BP theme doesn't come equipped with a browser detection class, you could use a CSS hack:

*:first-child+html .generic-button {display:inline;}

This only targets IE7 and is valid CSS.

IE6 will also need the width to be defined.

You can do so with the star hack:

* html .generic-button {width:150px;}

Even when you have the width defined, the generic button still won't look right, but it will look better than before.

---

I've attached a patch for trunk BP 1.1.1. It's untested since I don't have BP 1.1.1 installed on my testbox yet ;)

Please test!

comment:5 r-a-y5 years ago

  • Keywords has-patch added
  • Summary changed from IE 7 renders sign up button incorrectly to IE 7 renders sign up button incorrectly [Has patch]

comment:6 Jason_JM5 years ago

  • Keywords needs-testing added

comment:7 Jason_JM5 years ago

I'll try to test this tonight.

comment:8 Jason_JM5 years ago

  • Cc Jason_JM added

comment:9 Jason_JM5 years ago

  • Owner set to r-a-y
  • Status changed from new to assigned

comment:10 Takeo4 years ago

To clarify, IE7 does supports inline-block... sort of. It only supports it on elements which are inline by default (i.e. span, em, b). So applying it to a div element will have no effect.

The hack above in the comments should work but not without setting hasLayout using something like zoom:1; So:

'*:first-child+html .generic-button {zoom:1; display:inline;}'

or simply

generic-button {zoom:1; *display:inline;}

comment:11 r-a-y4 years ago

Takeo,

zoom isn't a valid CSS attribute, and while *display does work, it's also invalid.

You're right about the hasLayout/inline thing for IE7 though. I'm not using the default BP theme, so I can't tell if hasLayout is already applied or not.

Feel free to submit a patch though!

comment:12 apeatling4 years ago

  • Milestone set to 1.2

comment:13 apeatling4 years ago

  • Priority changed from minor to trivial

comment:14 apeatling4 years ago

  • Milestone changed from 1.2 to 1.2.1

Use IE8, and this is the classic theme so I'm bumping this unless someone gets a good patch in.

comment:15 hnla4 years ago

  • Component set to Core

Using IE8 is a nice suggestion and we wish everyone would but the reality is that not everyone can upgrade, remember BP suggests corporate use, intranets? for many large orgs upgrading browsers on a network is not a trivial matter as they have apps written for older browsers, some orgs have stated that upgrading will NOT happen - Orange & MOD procurement in the UK.

The approach that has been deemed 'Best Practice' for a while now and acknowledged by MS is to use MS Conditional Comments to filter a IE-fixes.css sheet to IE only, this way you do not need any other browser detection methods.

In that sheet one places override rules and the use of zoom:1; is a standard practice to set hasLayout - validation of this sheet is a non issue and irrelevant.

BP could do with adding a CC stylesheet to header.php or users could add through a add action wp_head in functions.php and corrections added to that rather than adding 'hacks' to the proper styles, 'hacks' are pretty much redundant and many have consequences; relying on a bug to correct an issue is dangerous as the bug could be corrected at a later revision.

comment:16 paulhastings04 years ago

  • Summary changed from IE 7 renders sign up button incorrectly [Has patch] to [patch] IE 7 renders sign up button incorrectly [Has patch]

comment:17 DJPaul3 years ago

  • Keywords internet explorer css has-patch needs-testing removed
  • Owner changed from r-a-y to DJPaul

Does this still apply to BP 1.2.6? I note this ticket was referring to the classic theme. I'm tempted to close this as wontfix unless 1.2.6's BP-Default has a similar problem.

comment:18 r-a-y3 years ago

I would say this doesn't apply anymore.

comment:19 DJPaul3 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

Closing as the Classic theme won't be supported in BP 1.3.

Note: See TracTickets for help on using tickets.