Skip to:
Content

Opened 5 years ago

Closed 3 years ago

#1086 closed defect (bug) (fixed)

At Inbox (Messages component) Month needs to be translated

Reported by: j.conti Owned by:
Milestone: 1.5 Priority: major
Severity: Version:
Component: Core Keywords: has-patch
Cc:

Description

In the messages component, the month needs to be translated.

See attachment

Attachments (2)

fecha.JPG (23.3 KB) - added by j.conti 5 years ago.
1086-1.patch (500 bytes) - added by boonebgorges 3 years ago.

Download all attachments as: .zip

Change History (9)

j.conti5 years ago

comment:1 apeatling5 years ago

  • Milestone changed from 1.1 to 1.2

There's a problem with the function date_il8n() that will fix this. This will be bumped to version 1.2.

You can change your date format in the WordPress settings to something that doesn't output English names for the time being.

comment:2 apeatling4 years ago

  • Keywords needs-patch added

Needs patch (that does not use date_il8n() that breaks on negative timestamps).

comment:3 johnjamesjacoby4 years ago

http://core.trac.wordpress.org/ticket/11226

The WordPress trac ticket talking about the crux of this issue. Props nacin for finding this for me.

comment:4 apeatling4 years ago

  • Milestone changed from 1.2 to 1.2.1

Bumping this unless someone can procure a working patch that doesn't break adding your birthday to your profile using a date box.

boonebgorges3 years ago

comment:5 boonebgorges3 years ago

  • Component set to Core
  • Resolution set to worksforme
  • Status changed from new to closed

Is this still an issue?

There seem to be a couple separate things going on here.

1) One problem is the one linked to in the (apparently dead) WP trac ticket. That has to do with declension and other noun forms not seen in English. But Spanish (the language of the OP) nouns don't decline. Moreover, if this were a declension problem, the screenshot would show the month name in the wrong case, not totally untranslated. So I don't think it has anything to do with the issue of declension, or really with date_l18n() at all.

2) I'm not sure I understand the problem that Andy's raising regarding dateboxes. I assume he's talking about bp_format_date, and in particular the line that hardcodes the date format. Given that this is just a display function, I'm not sure why it would have any effect on the information you can add with a datebox profile field. I just patched my local version with the attached patch 1068-1.patch and datebox selectors worked fine. BTW I think that the attached patch is a good idea, though again it's not really related to the OP's problem, which had to do with non-translation, not incorrect translation

3) My sense is that the OP's problem is this: buddypress-es_ES.mo had been installed, but not es_ES.mo (the regular WP language pack). Since date translations come from WP core, this would explain why the OP wasn't seeing date translations. I installed the Spanish language packs for BuddyPress and WP and dates seem to be working fine throughout.

I'm going to close this ticket because I don't really think there's an issue here. If I'm misunderstanding the root problem (possible!!), please reopen.

comment:6 nacin3 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution worksforme deleted
  • Status changed from closed to reopened

This should be either date_i18n( __( 'F j, Y' ) ... or date_i18n( get_option( 'date_format' ) ....

The former if you are looking for a specific format to be implemented. (It should be translatable, and yes, translators will realize this is a date.) But the latter is likely proper in this situation. The core date_format should be respected here, it's why it exists.

comment:7 djpaul3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3454]) Use WP core date_format for message component inbox. Fixes #1086, props boonebgorges and nacin

Note: See TracTickets for help on using tickets.