Changeset 9012 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

09/14/2014 10:50:01 AM (10 years ago)

Author:

djpaul

Message:

Core: only return forums from bp_core_get_packaged_component_ids() if using bbPress 1.

This otherwise causes the bbPress 2's subnav bar to not be rendered in templates due to the behaviour of members/single/plugins.php.

We would normally consider using bp_is_active for this kind of check, but because both bbPress 1 and (possibly, in the future) 2 could return true, we need a more reliable check for bbPress 1 only; see the ticket for full details.

See #5552. Fixes #5873, props r-a-y.

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -346 +346 @@
  */
 function bp_core_get_packaged_component_ids() {
-    return array(
+    $components = array(
         'activity',
         'members',
@@ -356 +356 @@
         'settings',
         'notifications',
-        'forums',
     );
+
+    // only add legacy forums if it is enabled
+    // prevents conflicts with bbPress, which also uses the same 'forums' id
+    if ( class_exists( 'BP_Forums_Component' ) ) {
+        $components[] = 'forums';
+    }
+
+    return $components;
 }