Changeset 9177 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

11/25/2014 03:33:45 PM (10 years ago)

Author:

boonebgorges

Message:

Improve matching between active component status and directory page status.

• When a directory page is deleted, delete the corresponding entry from bp_pages. This ensures that the admin will see the admin_notice that a page mapping is missing.
• When pulling up page mappings with bp_core_get_directory_page_ids(), remove entries corresponding to deleted pages and deactivated components.

Props Mamaduka.
Fixes #5681.

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -382 +382 @@
         foreach( (array) $page_ids as $component_name => $page_id ) {
             if ( empty( $component_name ) || empty( $page_id ) ) {
-                unset( $page_ids[$component_name] );
+                unset( $page_ids[ $component_name ] );
+            }
+
+            if ( ! bp_is_active( $component_name ) || 'trash' == get_post_status( $page_id ) ) {
+                unset( $page_ids[ $component_name ] );
             }
         }
@@ -566 +570 @@
     }
 }
+
+/**
+ * Remove the entry from bp_pages when the corresponding WP page is deleted.
+ *
+ * @since BuddyPress (2.2.0)
+ *
+ * @param int $post_id Post ID.
+ */
+function bp_core_on_directory_page_delete( $post_id ) {
+    $page_ids = bp_core_get_directory_page_ids();
+    $component_name = array_search( $post_id, $page_ids );
+
+    if ( ! empty( $component_name ) ) {
+        unset( $page_ids[ $component_name ] );
+    }
+
+    bp_core_update_directory_page_ids( $page_ids );
+}
+add_action( 'delete_post', 'bp_core_on_directory_page_delete' );
 
 /**