Changeset 13448 for trunk/src/bp-core/bp-core-template.php

Timestamp:

04/07/2023 07:47:34 AM (17 months ago)

Author:

imath

Message:

Do 404 when trying to reach a page about an unregistered group type

Improves the way we handle this case making sure we really end up to a
404 if the corresponding group type is not registered or do not support
directory filtering. Update corresponding PHP unit tests to really test
this case instead of a case about a member type.

Closes ​https://github.com/buddypress/buddypress/pull/82
Fixes #8866

File:

• trunk/src/bp-core/bp-core-template.php (modified) (1 diff)

trunk/src/bp-core/bp-core-template.php

@@ -2780 +2780 @@
  */
 function bp_is_groups_directory() {
-    if ( bp_is_groups_component() && ! bp_is_group() && ( ! bp_current_action() || ( bp_action_variable() && bp_is_current_action( bp_get_groups_group_type_base() ) ) ) ) {
-        return true;
-    }
-
-    return false;
+    $return = false;
+
+    if ( bp_is_groups_component() && ! bp_is_group() ) {
+        $return = ! bp_current_action() || ! empty( buddypress()->groups->current_directory_type );
+    }
+
+    return $return;
 }