Changeset 13449 for trunk/src/bp-core/bp-core-template.php

Timestamp:

04/08/2023 06:31:46 AM (18 months ago)

Author:

imath

Message:

Make sure all Groups component URLs are built using BP rewrites API

• Introduce the bp_groups_get_create_url() to ease Groups create URLs generation.
• Improve bp_groups_get_path_chunks() to deal with front-end group admin URLs and the Groups create URLs.
• Deprecate bp_get_groups_directory_permalink() in favor of bp_get_groups_directory_url().
• Replace all remaining deprecated functions usage.
• Start putting deprecated functions behind a function_exists( 'bp_classic' ) check, corresponding functions were added inside the BP Classic backcompat plugin.
• Adjust some Groups routing unit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/83
See #4954

File:

• trunk/src/bp-core/bp-core-template.php (modified) (1 diff)

trunk/src/bp-core/bp-core-template.php

@@ -1451 +1451 @@
     echo esc_url( bp_get_root_url() );
 }
-
-/**
- * Output the "root domain", the URL of the BP root blog.
- *
- * @since 1.1.0
- * @deprecated 12.0.0
- */
-function bp_root_domain() {
-    _deprecated_function( __FUNCTION__, '12.0.0', 'bp_root_url()' );
-    bp_root_url();
-}
-    /**
-     * Return the "root domain", the URL of the BP root blog.
-     *
-     * @since 1.1.0
-     * @deprecated 12.0.0
-     *
-     * @return string URL of the BP root blog.
-     */
-    function bp_get_root_domain() {
-        /*
-         * This function is used at many places and we need to review all this
-         * places during the 12.0 development cycle. Using BP Rewrites means we
-         * cannot concatenate URL chunks to build our URL anymore. We now need
-         * to use `bp_rewrites_get_url( $array )` and make sure to use the right
-         * arguments inside this `$array`.
-         *
-         * @todo Once every link reviewed, we'll be able to remove this check
-         *       and let PHPUnit tell us the one we forgot, eventually!
-         */
-        if ( ! buddypress()->is_phpunit_running ) {
-            _deprecated_function( __FUNCTION__, '12.0.0', 'bp_get_root_url()' );
-        }
-
-        $domain = bp_get_root_url();
-
-        /**
-         *  Filters the "root domain", the URL of the BP root blog.
-         *
-         * @since 1.2.4
-         * @deprecated 12.0.0 Use {@see 'bp_get_root_url'} instead.
-         *
-         * @param string $domain URL of the BP root blog.
-         */
-        return apply_filters_deprecated( 'bp_core_get_root_domain', array( $domain ), '12.0.0', 'bp_get_root_url' );
-    }
 
 /**