Changeset 13433 for trunk/tests/phpunit/testcases/routing/members.php

Timestamp:

03/07/2023 04:28:08 AM (21 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/routing/members.php (modified) (10 diffs)

trunk/tests/phpunit/testcases/routing/members.php

@@ -6 +6 @@
 class BP_Tests_Routing_Members extends BP_UnitTestCase {
     protected $old_current_user = 0;
+    protected $permalink_structure = '';
 
     public function set_up() {
@@ -12 +13 @@
         buddypress()->members->types = array();
         $this->old_current_user = get_current_user_id();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
         $this->set_current_user( self::factory()->user->create( array( 'user_login' => 'paulgibbs', 'role' => 'subscriber' ) ) );
     }
@@ -17 +19 @@
     public function tear_down() {
         $this->set_current_user( $this->old_current_user );
+        $this->set_permalink_structure( $this->permalink_structure );
         parent::tear_down();
     }
 
     function test_members_directory() {
+        $this->set_permalink_structure( '/%postname%/' );
         $this->go_to( bp_get_members_directory_permalink() );
 
@@ -30 +34 @@
 
     function test_member_permalink() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to( bp_members_get_user_url( bp_loggedin_user_id() ) );
         $this->assertTrue( bp_is_my_profile() );
     }
@@ -39 +44 @@
      */
     public function test_member_directory_with_member_type() {
+        $this->set_permalink_structure( '/%postname%/' );
         bp_register_member_type( 'foo' );
         $this->go_to( bp_get_members_directory_permalink() . 'type/foo/' );
@@ -49 +55 @@
      */
     public function test_member_directory_with_member_type_should_obey_filtered_type_slug() {
+        $this->set_permalink_structure( '/%postname%/' );
         bp_register_member_type( 'foo' );
 
@@ -66 +73 @@
      */
     public function test_member_directory_with_member_type_that_has_custom_directory_slug() {
+        $this->set_permalink_structure( '/%postname%/' );
         bp_register_member_type( 'foo', array( 'has_directory' => 'foos' ) );
         $this->go_to( bp_get_members_directory_permalink() . 'type/foos/' );
@@ -76 +84 @@
      */
     public function test_member_directory_with_member_type_should_be_overridden_by_member_with_same_nicename() {
+        $this->set_permalink_structure( '/%postname%/' );
         $u = self::factory()->user->create( array( 'user_nicename' => 'foo' ) );
         bp_register_member_type( 'foo' );
@@ -91 +100 @@
      */
     public function test_member_directory_should_404_for_member_types_that_have_no_directory() {
+        $this->set_permalink_structure( '/%postname%/' );
         bp_register_member_type( 'foo', array( 'has_directory' => false ) );
         $this->go_to( bp_get_members_directory_permalink() . 'type/foo/' );
@@ -100 +110 @@
      */
     function test_members_shortlink_redirector() {
+        $this->set_permalink_structure( '/%postname%/' );
         $shortlink_member_slug = 'me';