Changeset 13468 for trunk/tests/phpunit/testcases/routing/members.php

Timestamp:

05/03/2023 06:18:23 AM (3 years ago)

Author:

imath

Message:

Stop using BP Legacy URL parser in favor of the new BP Rewrites API

• Deprecate bp_core_set_uri_globals(). This function is moved inside the BP Classic compatibility plugin.
• Introduce the new bp_register_nav action to hook to when globalizing Members single item navigations from the BP_Component class.
• Improve bp_get_component_navigations() so that Avatar/Cover images navigation items are moved inside the Profile sub nav if the Extended profile component is active.
• Register Avatar/Cover images Ajax actions so that these actions trigger our new URL Parser inside Ajax context.
• Improve the BP_Core_Nav::add_nav() method so that any BP action variable slugs can be customized.
• Improve Members & Groups component canonical redirections.
• Handle slugs customization persistency using directory pages post metas.
• Introduce a new repair tool to reset all slugs to BuddyPress default one.
• Adapt some PHPUnit tests to better handle our new URL parser.

Props Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/94
See #4954

File:

• trunk/tests/phpunit/testcases/routing/members.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/routing/members.php

@@ -46 +46 @@
         $this->set_permalink_structure( '/%postname%/' );
         bp_register_member_type( 'foo' );
-        $this->go_to( bp_get_members_directory_permalink() . 'type/foo/' );
+        $url = bp_get_member_type_directory_permalink( 'foo' );
+        $this->go_to( $url );
         $this->assertTrue( bp_is_members_component() );
     }
@@ -59 +60 @@
 
         add_filter( 'bp_members_member_type_base', array( $this, 'filter_member_type_base' ) );
-        $this->go_to( bp_get_members_directory_permalink() . 'buddypress-member-type/foo/' );
+
+        $url = bp_get_member_type_directory_permalink( 'foo' );
+
         remove_filter( 'bp_members_member_type_base', array( $this, 'filter_member_type_base' ) );
-        $this->assertTrue( bp_is_members_component() );
+
+        $this->assertSame( $url, 'http://example.org/members/bp-member-type/foo/' );
     }
 
     public function filter_member_type_base( $base ) {
-        return 'buddypress-member-type';
+        return 'bp-member-type';
     }