Changeset 13312 for trunk/src/bp-core/bp-core-avatars.php

Timestamp:

08/13/2022 08:21:06 AM (2 years ago)

Author:

imath

Message:

Avoid various PHP 8.1 deprecated notices

Here are the treated deprecated notices:

• ctype_digit() Argument of type int will be interpreted as string in the future.
• Automatic conversion of false to array.
• Passing null to strtotime() $datetime parameter.

Props renatonascalves, rafiahmedd

See #8649

File:

• trunk/src/bp-core/bp-core-avatars.php (modified) (1 diff)

trunk/src/bp-core/bp-core-avatars.php

@@ -811 +811 @@
 
         /** This filter is documented in bp-core/bp-core-avatars.php */
-        $item_id = apply_filters( 'bp_core_avatar_item_id', $args['item_id'], $args['object'] );
+        $item_id = (int) apply_filters( 'bp_core_avatar_item_id', $args['item_id'], $args['object'] );
     } else {
-        $item_id = $args['item_id'];
-    }
-
-    if ( $item_id && ( ctype_digit( $item_id ) || is_int( $item_id ) ) ) {
-        $item_id = (int) $item_id;
-    } else {
+        $item_id = (int) str_replace( '.', '', $args['item_id'] );
+    }
+
+    if ( ! $item_id ) {
         return false;
     }