Changeset 13311 for trunk/src/bp-core/bp-core-avatars.php

Timestamp:

08/09/2022 06:23:32 PM (3 years ago)

Author:

imath

Message:

Avoid PHP 8.1 ArrayAccess Return Type deprecation notices

The BP_Core_BP_Nav_BackCompat is implementing the ArrayAccess class to provide backward compatibility to BuddyPress plugins directly modifying the buddypress()->bp_nav global since BuddyPress 2.3.

PHP 8.1 added a deprecation notice if a class declaration has an incompatible return type (or if the return type lacks: which is the case for BP_Core_BP_Nav_BackCompat) with the parent it extends.

As BuddyPress supports PHP back to version 5.6, we need to use the #ReturnTypeWillChange attribute to maintain compatibility with this version and avoid the deprecation notice in PHP 8.x.

Fixes #8726

File:

• trunk/src/bp-core/bp-core-avatars.php (modified) (1 diff)

trunk/src/bp-core/bp-core-avatars.php

@@ -457 +457 @@
     // Use an alias to leave the param unchanged.
     $avatar_classes = $params['class'];
-    if ( ! is_array( $avatar_classes ) ) {
+    if ( is_null( $avatar_classes ) ) {
+        $avatar_classes = array();
+    } elseif ( ! is_array( $avatar_classes ) ) {
         $avatar_classes = explode( ' ', $avatar_classes );
     }