Changeset 10555 for trunk/src/bp-settings/classes/class-bp-settings-component.php

Timestamp:

02/08/2016 05:56:22 AM (11 years ago)

Author:

r-a-y

Message:

BP Component: Allow plugins to set a custom position when registering an admin bar subnav menu.

This commit allows plugins to set a 'position' key when registering a WP
Admin Bar subnav menu item in the setup_admin_bar() method.

Previously, plugins had to do all sorts of array shuffling in order to
register their subnav at a preferred position. For backward compatibility,
we do some 'position' key backfilling, so if a plugin isn't using the new
'position' key, their subnav should still display at the same location.

Fixes #6859.

File:

• trunk/src/bp-settings/classes/class-bp-settings-component.php (modified) (2 diffs)

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -184 +184 @@
                         // General Account.
                         $wp_admin_nav[] = array(
-                                'parent' => 'my-account-' . $this->id,
-                                'id'     => 'my-account-' . $this->id . '-general',
-                                'title'  => __( 'General', 'buddypress' ),
-                                'href'   => $settings_link
+                                'parent'   => 'my-account-' . $this->id,
+                                'id'       => 'my-account-' . $this->id . '-general',
+                                'title'    => __( 'General', 'buddypress' ),
+                                'href'     => $settings_link,
+                                'position' => 10
                         );
 
@@ -193 +194 @@
                         if ( has_action( 'bp_notification_settings' ) ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-notifications',
-                                        'title'  => __( 'Email', 'buddypress' ),
-                                        'href'   => trailingslashit( $settings_link . 'notifications' )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-notifications',
+                                        'title'    => __( 'Email', 'buddypress' ),
+                                        'href'     => trailingslashit( $settings_link . 'notifications' ),
+                                        'position' => 20
                                 );
                         }
 
-                        // Delete Account.
+                        // Delete Account
                         if ( !bp_current_user_can( 'bp_moderate' ) && ! bp_core_get_root_option( 'bp-disable-account-deletion' ) ) {
                                 $wp_admin_nav[] = array(
-                                        'parent' => 'my-account-' . $this->id,
-                                        'id'     => 'my-account-' . $this->id . '-delete-account',
-                                        'title'  => __( 'Delete Account', 'buddypress' ),
-                                        'href'   => trailingslashit( $settings_link . 'delete-account' )
+                                        'parent'   => 'my-account-' . $this->id,
+                                        'id'       => 'my-account-' . $this->id . '-delete-account',
+                                        'title'    => __( 'Delete Account', 'buddypress' ),
+                                        'href'     => trailingslashit( $settings_link . 'delete-account' ),
+                                        'position' => 90
                                 );
                         }