Changeset 11926 for trunk/src/bp-settings/classes/class-bp-settings-component.php

Timestamp:

04/02/2018 02:58:28 AM (8 years ago)

Author:

r-a-y

Message:

Settings: Conditionally load action and screen functions.

This commit conditionally loads action and screen function code for the
Settings component, utilizing the 'bp_late_include' hook introduced in
r11884.

Previously, we loaded these functions at all times, which is unnecessary
when a user is not on a BuddyPress settings page. Now, we only load this
code when needed.

See #7218.

File:

• trunk/src/bp-settings/classes/class-bp-settings-component.php (modified) (1 diff)

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -43 +43 @@
         public function includes( $includes = array() ) {
                 parent::includes( array(
-                        'actions',
-                        'screens',
                         'template',
                         'functions',
                 ) );
+        }
+
+        /**
+         * Late includes method.
+         *
+         * Only load up certain code when on specific pages.
+         *
+         * @since 3.0.0
+         */
+        public function late_includes() {
+                // Bail if PHPUnit is running.
+                if ( defined( 'BP_TESTS_DIR' ) ) {
+                        return;
+                }
+
+                // Bail if not on Settings component.
+                if ( ! bp_is_settings_component() ) {
+                        return;
+                }
+
+                $actions = array( 'notifications', 'capabilities', 'delete-account' );
+
+                // Authenticated actions.
+                if ( is_user_logged_in() ) {
+                        if ( bp_is_current_action( 'general' ) ) {
+                                require $this->path . 'bp-settings/screens/general.php';
+
+                        // Specific to post requests.
+                        } elseif ( bp_is_post_request() && in_array( bp_current_action(), $actions, true ) ) {
+                                require $this->path . 'bp-settings/actions/' . bp_current_action() . '.php';
+                        }
+                }
+
+                // Screens - User profile integration.
+                if ( bp_is_user() ) {
+                        require $this->path . 'bp-settings/screens/general.php';
+
+                        // Sub-nav items.
+                        if ( in_array( bp_current_action(), $actions, true ) ) {
+                                require $this->path . 'bp-settings/screens/' . bp_current_action() . '.php';
+                        }
+                }
         }