Changeset 10205 for trunk/src/bp-groups/bp-groups-loader.php

Timestamp:

10/07/2015 03:56:36 PM (9 years ago)

Author:

imath

Message:

Groups Homes: make sure the action parameter of the canonical stack is reset to home in two specific cases.

When the Group does not use a custom front.php template:
(1) If the Activity component is not active, the home page displays the members of the Group.
(2) If the Activity component is active, the home page displays the activities of the Group.

In case (1), a user trying to directly access to site.url/groups/single/members must be redirected
to the home page.
In case (2), a user trying to directly access to site.url/groups/single/activity must be redirected to the home page.

Props jmarx75 (Congrats for your first ticket and patch, welcome on board!)

Fixes #6646

File:

• trunk/src/bp-groups/bp-groups-loader.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-loader.php

@@ -391 +391 @@
         }
 
+        /**
+         * If there's no custom front.php template for the group, we need to make sure the canonical stack action
+         * is set to 'home' in these 2 cases:
+         *
+         * - the current action is 'activity' (eg: site.url/groups/single/activity) and the Activity component is active
+         * - the current action is 'members' (eg: site.url/groups/single/members) and the Activity component is *not* active.
+         */
+        if ( ! $this->current_group->front_template && ( bp_is_current_action( 'activity' ) || ( ! bp_is_active( 'activity' ) && bp_is_current_action( 'members' ) ) ) ) {
+            $bp->canonical_stack['action'] = 'home';
+        }
+
         if ( ! empty( $bp->action_variables ) ) {
             $bp->canonical_stack['action_variables'] = bp_action_variables();