Changeset 10184 for trunk/src/bp-groups/bp-groups-loader.php

Timestamp:

10/04/2015 01:47:36 PM (9 years ago)

Author:

imath

Message:

Improve template loading for Groups single items home pages.

• Make sure an activity sub navigation will be generated if the displayed group has a custom front page.
• Make sure no members sub navigation is generated if the activity component is not active and the Group has no custom front. As, in this case the home page of the group is already displaying the members template.
• Make sure some Groups single item conditional tags are behaving the right way:
  • bp_is_group_home() is true when on the home page of the group (eg: site.url/groups/single-group/).
  • bp_is_group_activity() is true when the activity page of the group is displayed. It can be the home page of the group or its activity page (eg: site.url/groups/single-group/activity).
  • bp_is_group_members() is true when the members page of the group is displayed. It can be the home page of the group or its members page (eg: site.url/groups/single-group/members).
• Introduce a new conditional tag: bp_is_group_custom_front() to check if the home page of the group is using a custom front template.
• Introduce a new template tag bp_groups_front_template_part() used to choose the appropriate template to load for the home page of the group (activity, members, or the custom front).
• Introduce a template hierarchy for the buddypress/groups/single/front.php template so that it is possible to have different front pages according to the ID, slug or status of the Group.
• And finally make sure the introduced improvements are back compatible with themes who forgot to update their buddypress/groups/single/home.php and buddypress/activity/post-form.php templates.

Props r-a-y, boonebgorges, DJPaul, and imath :)

Fixes #6388

File:

• trunk/src/bp-groups/bp-groups-loader.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-loader.php

@@ -251 +251 @@
                 $this->current_group->user_has_access = true;
             }
+
+            // Check once if the current group has a custom front template
+            $this->current_group->front_template = bp_groups_get_front_template( $this->current_group );
 
         // Set current_group to 0 to prevent debug errors
@@ -372 +375 @@
         $bp = buddypress();
 
+        // If the activity component is not active and the current group has no custom front, members are displayed in the home nav
+        if ( 'members' === $this->default_extension && ! bp_is_active( 'activity' ) && ! $this->current_group->front_template ) {
+            $this->default_extension = 'home';
+        }
+
         if ( ! bp_current_action() ) {
             $bp->current_action = $this->default_extension;
@@ -528 +536 @@
             }
 
-            $sub_nav[] = array(
-                'name'            => sprintf( _x( 'Members <span>%s</span>', 'My Group screen nav', 'buddypress' ), number_format( $this->current_group->total_member_count ) ),
-                'slug'            => 'members',
-                'parent_url'      => $group_link,
-                'parent_slug'     => $this->current_group->slug,
-                'screen_function' => 'groups_screen_group_members',
-                'position'        => 60,
-                'user_has_access' => $this->current_group->user_has_access,
-                'item_css_id'     => 'members',
-                'no_access_url'   => $group_link,
-            );
+            if ( $this->current_group->front_template || bp_is_active( 'activity' ) ) {
+                /**
+                 * If the theme is using a custom front, create activity subnav.
+                 */
+                if ( $this->current_group->front_template && bp_is_active( 'activity' ) ) {
+                    $sub_nav[] = array(
+                        'name'            => _x( 'Activity', 'My Group screen nav', 'buddypress' ),
+                        'slug'            => 'activity',
+                        'parent_url'      => $group_link,
+                        'parent_slug'     => $this->current_group->slug,
+                        'screen_function' => 'groups_screen_group_activity',
+                        'position'        => 11,
+                        'user_has_access' => $this->current_group->user_has_access,
+                        'item_css_id'     => 'activity',
+                        'no_access_url'   => $group_link,
+                    );
+                }
+
+                /**
+                 * Only add the members subnav if it's not the home's nav
+                 */
+                $sub_nav[] = array(
+                    'name'            => sprintf( _x( 'Members <span>%s</span>', 'My Group screen nav', 'buddypress' ), number_format( $this->current_group->total_member_count ) ),
+                    'slug'            => 'members',
+                    'parent_url'      => $group_link,
+                    'parent_slug'     => $this->current_group->slug,
+                    'screen_function' => 'groups_screen_group_members',
+                    'position'        => 60,
+                    'user_has_access' => $this->current_group->user_has_access,
+                    'item_css_id'     => 'members',
+                    'no_access_url'   => $group_link,
+                );
+            }
 
             if ( bp_is_active( 'friends' ) && bp_groups_user_can_send_invites() ) {