Skip to:
Content

BuddyPress.org

Opened 6 months ago

Closed 5 weeks ago

#9298 closed defect (bug) (fixed)

Activity feed atom href code triggers PHP Deprecated in logs

Reported by: needle's profile needle Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 14.5.0 Priority: normal
Severity: normal Version: 14.3.2
Component: Activity Keywords: has-patch commit
Cc:

Description

Line 444 of class-bp-activity-feed.php currently reads:

<atom:link href="<?php esc_url( self_link() ); ?>" rel="self" type="application/rss+xml" />

It should read:

<atom:link href="<?php self_link(); ?>" rel="self" type="application/rss+xml" />

Since self_link() already echoes.

I'll open a PR on GitHub.

Change History (4)

This ticket was mentioned in ​PR #416 on ​buddypress/buddypress by ​@needle.
6 months ago #1

  • Keywords has-patch added

Avoids PHP Deprecated noise in logs and fixes the ATOM feed URL for Activities.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9298

#2 @johnjamesjacoby
6 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 15.0.0
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#3 @espellcaste
5 weeks ago

  • Milestone changed from 15.0.0 to 14.5.0

#4 @espellcaste
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 14142:

Restore the link from the Activity feed atom.

This resolves a regression introduced at [13816], where the self_link no longer was
echoing the link from the atom feed.

Since self_link already echoes the link, we do not need to run esc_url again.

Props needle and johnjamesjacoby.

Fixes #9298 (14.0)

Note: See TracTickets for help on using tickets.