Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

#9171 closed defect (bug) (fixed)

bp_user_has_opted_out() is misused in bp_email_unsubscribe_handler()

Reported by: dcavins Owned by: DJPaul
Priority: normal Milestone: 14.0.0
Component: Emails Version: 12.5.0
Severity: normal Keywords:
Cc:

Description

In bp_email_unsubscribe_handler(), bp_user_has_opted_out() is called without passing an email, which must be supplied.

Attachments (1)

9171.1.diff​ (643 bytes ) - added by dcavins 2 years ago.
Pass email to bp_user_has_opted_out().

Download all attachments as: .zip

Change History (2)

@dcavins
2 years ago

Pass email to bp_user_has_opted_out().

#1 @dcavins
2 years ago

  • Resolution → fixed
  • Status new → closed

In 13908:

Make sure to pass an email address to bp_user_has_opted_out().

In bp_email_unsubscribe_handler() we missed passing the incoming email to bp_user_has_opted_out().
It's hard to figure out whether a user has opted out if you don't check the user's email address.

Props emeralive.

Fixes #9171.

Note: See TracTickets for help on using tickets.