Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#9142 closed defect (bug) (fixed)

Fatal error from bp-activity/bp-activity-admin.php

Reported by: respawnsive Owned by: imath
Priority: high Milestone: 12.5.0
Component: Activity Version: 12.4.1
Severity: major Keywords: has-patch
Cc:

Description

A fatal error is caused by a bad placed parenthesis in commit c0f0ca2 (5 days ago).
A pull request will be submitted.

Change History (5)

This ticket was mentioned in ​PR #276 on ​buddypress/buddypress by ​clement-cdy.
2 years ago #1

  • Keywords has-patch added

Correct a parenthesis error causing a fatal error in admin panel

Just correcting a parenthesis error

#2 @imath
2 years ago

  • Component (not sure) → Activity
  • Milestone Awaiting Review → 12.5.0
  • Version → 12.4.1

Hi @respawnsive

Thanks a lot for your patch. It's a regression introduced in 12.4.1. I suspect there might be some others even if I tried to apply output escapes very carefully.

#3 @imath
2 years ago

In 13842:

Activity Admin: fix an error happening when performing a search

This regression was introduced in r13816.

Props respawnsive

See #9142 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/276

#4 @imath
2 years ago

  • Owner set to imath
  • Resolution → fixed
  • Status new → closed

In 13843:

Activity Admin: fix an error happening when performing a search

This regression was introduced in r13816.

Props respawnsive

Fixes #9142 (branch 12.0)

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
2 years ago

Note: See TracTickets for help on using tickets.