Skip to:
Content

BuddyPress.org

Opened 19 months ago

Closed 18 months ago

#9129 closed enhancement (fixed)

Support object cache services (memcached/redis) in CI tests

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 14.0.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Cc:

Description (last modified by espellcaste)

Set up CI for testing against Memcache or/and Redis.

See #9076

Change History (12)

This ticket was mentioned in ​PR #266 on ​buddypress/buddypress by ​renatonascalves.
19 months ago #1

  • Keywords has-patch added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9129

#2 @espellcaste
19 months ago

Unfortunately, the wp-env project doesn't have support for the object cache service, like Redis or Memcached.

#3 @espellcaste
19 months ago

  • Keywords has-patch removed
  • Milestone changed from 14.0.0 to Under Consideration

This ticket was mentioned in ​Slack in #buddypress by espellcaste. ​View the logs.
19 months ago

#5 @espellcaste
19 months ago

  • Milestone changed from Under Consideration to 14.0.0

It was agreed that a new Github Action can be used here since it doesn’t seem possible to use the WordPress env package.

I'll work on it.

#7 @espellcaste
19 months ago

  • Description modified (diff)

This ticket was mentioned in ​PR #284 on ​buddypress/buddypress by ​renatonascalves.
19 months ago #8

  • Keywords has-patch added

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9129

​renatonascalves commented on ​PR #284:
19 months ago #9

This is working, but the unit tests are breaking with redis. Need to investigate why.

​renatonascalves commented on ​PR #284:
18 months ago #10

It works. Pending item is to make this failing unit test.

​imath commented on ​PR #284:
18 months ago #11

@renatonascalves It looks great! Feel free to commit it on SVN Trunk. Amazing work 👏

#12 @espellcaste
18 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13859:

Unit tests are run with Memcache or/and Redis in CI (Continuous Integration)

A new Github Action is added with a simple matrix to run our unit tests with object cache services, currently Memcache and Redis.

Props imath
See #9076
Fixes #9129
Closes ​https://github.com/buddypress/buddypress/pull/284

Note: See TracTickets for help on using tickets.