Opened 9 months ago
Closed 9 months ago
#9074 closed defect (bug) (fixed)
Attributes in block.json files are not translated
Reported by: | imath | Owned by: | slaFFik |
---|---|---|---|
Milestone: | 12.3.0 | Priority: | normal |
Severity: | normal | Version: | 12.0.0 |
Component: | I18N | Keywords: | has-patch |
Cc: |
Description
Here's the list of blocks to check:
- Latests activities (title attribute)
- Recent Networkwide Posts (title attribute)
- Dynamic Groups List (title attribute)
- Recently Active Members (title attribute)
- Dynamic Members List (title attribute)
- Online Members (title attribute)
Change History (6)
This ticket was mentioned in PR #223 on buddypress/buddypress by @imath.
9 months ago
#1
- Keywords has-patch added; needs-patch removed
9 months ago
#3
The main problem was with the Latest Activities block, something that used to work previously (setting the postId attribute once the block is added to a post) is now generating an error preventing the Activity Types select box to appear etc.. So I had to use a workaround 😓 .
I noticed it while working on a way to have the default Blocks title translated. Using Block attributes in the block.json file was a wrong idea. Title, description are translated but not attributes.
1) Fix the Latest Activities block:
activity/widget
template when BP Nouveau is the active template pack.wp_list_pluck()
preventing activity types to be fetched for the block.2) For BP Blocks using a
title
attributes, make sure the default one can be translated.Trac ticket: https://buddypress.trac.wordpress.org/ticket/9074