Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

#9023 closed defect (bug) (fixed)

BP Nouveau: improve cover image header's action button consistency

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch
Cc:

Description

So far action buttons are wrapped inside an <ul> container which is fine as long as you don't click on the friendship button. When you do so the <li> element is replaced with a <div> element once the Ajax action is achieved. To preserve well formed tags we should use the same way the regular member header displays these action buttons (wrapped into a <div> container.

Change History (2)

This ticket was mentioned in ​PR #191 on ​buddypress/buddypress by ​@imath.
2 years ago #1

  • Keywords has-patch added; needs-patch removed

Wrap the cover member header's action buttons into a <div>.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/9023

#2 @imath
2 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13644:

BP Nouveau: improve cover member header’s action buttons consistency

Wrap the cover member header's action buttons into a <div> to preserve well formed tags when a friendship Ajax action is fired by the corresponding action button.

Fixes #9023
Closes ​https://github.com/buddypress/buddypress/pull/191

Note: See TracTickets for help on using tickets.