Skip to:
Content

BuddyPress.org

Opened 16 months ago

Closed 6 weeks ago

#8986 closed defect (bug) (fixed)

Register page input values display in invalid state by default

Reported by: vapvarun's profile vapvarun Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version: 11.3.1
Component: Templates Keywords: has-patch
Cc:

Description

When validating registration fields, the invalid CSS class is applied on the first load of the registration form, even before filling in any values.

.buddypress-wrap .standard-form input[required]:invalid, .buddypress-wrap .standard-form select[required]:invalid, .buddypress-wrap .standard-form textarea[required]:invalid {
    border-color: #b71717;
}

buddypress/bp-templates/bp-nouveau/css/buddypress.min.css

We can replace it with the following to set the default when nothing is filled.

.buddypress-wrap .standard-form input[required], .buddypress-wrap .standard-form select[required], .buddypress-wrap .standard-form textarea[required] {
    border-color: #d6d6d6;;
}

After submitting values, we already have a different CSS object for the invalid one.

.buddypress-wrap .standard-form input.invalid[required], .buddypress-wrap .standard-form select.invalid[required], .buddypress-wrap .standard-form textarea.invalid[required] {
  border-color: #b71717;
}

Attachments (2)

Screenshot 2023-08-30 140611.png (146.0 KB) - added by vapvarun 16 months ago.
Register page with default theme
8986.patch (912 bytes) - added by upenwp12 15 months ago.
patch for #8986

Download all attachments as: .zip

Change History (10)

@vapvarun
16 months ago

Register page with default theme

@upenwp12
15 months ago

patch for #8986

#1 @espellcaste
6 months ago

  • Milestone changed from Awaiting Review to Up Next

@vapvarun Can you confirm if the patch above fixes your issue?

#2 @vapvarun
6 months ago

Yes, @espellcaste, the above patch will resolve the issue. It was created to help @upenwp12 start contributing to BuddyPress.

#3 @imath
5 months ago

  • Milestone changed from Up Next to 15.0.0

#4 @espellcaste
4 months ago

  • Keywords has-patch added
  • Owner set to espellcaste
  • Status changed from new to assigned

I'll look into applying the patch and confirming if it fixes the issue.

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


3 months ago

#6 @espellcaste
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 14063:

Register page input values display in invalid CSS state by default.

When validating registration fields, the invalid CSS class is applied on the first load of the registration form, even before filling in any values. (See ticket for visual aid).

Props vapvarun, upenwp12.

Fixes #8986

#7 @imath
6 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Let's not forget to grunt commit, this way we can figure out that to really fix this issue we need to edit the src/bp-templates/bp-nouveau/common-styles/_bp_forms.scss file 😅

#8 @imath
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 14064:

Register page input values display in invalid CSS state by default.

Update src/bp-templates/bp-nouveau/common-styles/_bp_forms.scss && grunt commit

Props vapvarun, upenwp12, espellcaste.

Fixes #8986

Note: See TracTickets for help on using tickets.