#8971 closed defect (bug) (fixed)
Logged in/out Members WP Nav Menu is failing in 12.0.0
Reported by: | imath | Owned by: | imath |
---|---|---|---|
Milestone: | 12.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Members | Keywords: | has-patch |
Cc: |
Description
Reported by @vapvarun here https://buddypress.org/support/topic/lets-prepare-the-buddypress-12-0-0-next-major-release/#post-330778
I tested and was able to reproduce. I confirm the issue
Change History (7)
This ticket was mentioned in PR #148 on buddypress/buddypress by @imath.
14 months ago
#1
- Keywords has-patch added; needs-patch removed
#2
@
14 months ago
- Owner set to imath
- Resolution set to fixed
- Status changed from new to closed
In 13547:
#3
@
14 months ago
Hi @imath Please check all tabs once, seems the HTML structure with tab index bp_nav_menu_item-search is not getting replaced with bp_nav_menu_item-all
https://prnt.sc/noJOTHxtw_cT
Test Env:
PHP v8.1.2
Screencast: https://somup.com/c0j2QoAQXa
#5
@
14 months ago
Sorry about that, I accidentally cloned from the old recipe which was using version 5.8.7.
#6
@
14 months ago
- Resolution set to fixed
- Status changed from reopened to closed
Ok I see what it is: it's because WordPress changed the output moving the class attribute after the id one see: https://core.trac.wordpress.org/changeset/55616/
It's another issue. I'm going to close this ticket as fixed and open another one to deal with this WP 6.3 change for BP 11.2 and up.
As the
'bp_parse_query'
is not fired inside WP Admin context, we need to use thebp_get_component_navigations()
function instead of trying to access the Members primaryBP_Core_Nav
.Trac ticket: https://buddypress.trac.wordpress.org/ticket/8971