Skip to:
Content

BuddyPress.org

Opened 17 months ago

Closed 17 months ago

#8955 closed task (fixed)

Only run the 12.0.0 upgrade routine if BP Classic is not active.

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 12.0.0 Priority: high
Severity: major Version:
Component: Core Keywords: needs-testing has-patch
Cc:

Description

I can imagine some users will want to absolutely keep a classic BuddyPress to preserve compatibility with third party plugins they know will not do the needed changes to support the BP Rewrites API.

A possible way to achieve this is to activate the BP Classic plugin - which only runs if BuddyPress is 12.0.0 or up - in anticipation of this upgrade while BuddyPress is still relative to branch 11.0. This means, we need to make sure our upgrade routine won't run if the BP Classic plugin is active.

I'll do the needed checks/tests to be sure of this asap.

Change History (4)

#1 @imath
17 months ago

  • Summary changed from Only run the 12.0.0 upgrade routing if BP Classic is not active. to Only run the 12.0.0 upgrade routine if BP Classic is not active.

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
17 months ago

This ticket was mentioned in ​PR #145 on ​buddypress/buddypress by ​@imath.
17 months ago #3

  • Keywords has-patch added
  • Only perform the BP Rewrites API & Legacy Widgets upgrade tasks when the BP Classic plugin is not active.
  • Add an action hook in case 3rd party plugins need to perform specific tasks once BP has been updated to 12.0.0.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8955

#4 @imath
17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13536:

Improve BuddyPress 12.0.0 upgrade tasks

  1. Only perform the BP Rewrites API & Legacy Widgets upgrade tasks when the BP Classic plugin is not active.
  2. Add an action hook in case 3rd party plugins need to perform specific tasks once BP has been updated to 12.0.0.

Fixes #8955
Closes ​https://github.com/buddypress/buddypress/pull/145

Note: See TracTickets for help on using tickets.