customizer_set_uri can cause depreciation notice in PHP 8.1

[thomaslhotta]

Hi

In the function customizer_set_uri on line 693 the 'query' key of $uri can be empty. If that is the case, a depreciation notice will be emitted.

I think the best solution would be to change the preceding else statement to an

else if ( ! empty( $uri['query'] ) {

because if the query key is empty the rest of the functionality does nothing anyway.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8920

[espellcaste]

This is a tricky one. The related method was deprecated since BuddyPress 12.0. But it is available in BuddyPress 11.2.0, which is where the issue is occurring.

We have a fix available ​here. But this fix is useless since mentioned, the code is deprecated in the latest version of BuddyPress.

I'd argue that we should not backport this to BP 11.2.0 since this is not a security issue, and advocate @thomaslhotta to upgrade BuddyPress instead.

But if we decide to backport this to 11, we have the patch ​here.

[espellcaste]

@imath What do you think?

[imath]

I agree with you @espellcaste, let's avoid the deprecated notice in 15.0 and up if people are still using this method although it's deprecated.

[espellcaste]

@imath This is an internal method used by the BP_Nouveau class, so the issue is not that external people are using it.

The issue happens in a previous version of BuddyPress (11.2.0), but since it was deprecated, the reported error is gone since the method is not used anymore internally.

I'd suggest removing the method in 15.0 rather than patch it.

[espellcaste]

@imath Pinging you to confirm if you agree with the suggestion above.

[imath]

I disagree! My bad, here's the explanation: ​https://github.com/buddypress/buddypress/pull/339/commits/0a65d4a790af65b6b693bb0ad1faaa69140f9af0

It's probably best to fix this earlier than 15.0.

[espellcaste]

@imath Awesome. But I assume we don't want to patch BP 11, right? Only in 14.1, correct?

[imath]

@espellcaste absolutely correct, we only patch back in case of security issues.

[espellcaste]

In 14003:

Fire the customizer_set_uri method for regular themes when BP Classic is activated.

Restore the deprecated (in BP 12.0) customizer_set_uri method since we still need to support it for regular themes using BP Classic.

We are also fixing a PHP 8.1 deprecated notice.

Props thomaslhotta, imath.

See #8920 (trunk)
Closes ​https://github.com/buddypress/buddypress/pull/339

[espellcaste]

In 14004:

Fire the customizer_set_uri method for regular themes when BP Classic is activated.

Restore the deprecated (in BP 12.0) customizer_set_uri method since we still need to support it for regular themes using BP Classic.

We are also fixing a PHP 8.1 deprecated notice.

Props thomaslhotta, imath.

Fixes #8920 (branch 14.0)